Warn on DynamicTable read validation issues#822
Merged
Conversation
18f5515 to
4addedc
Compare
3 tasks
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #822 +/- ##
==========================================
+ Coverage 95.26% 95.42% +0.15%
==========================================
Files 212 215 +3
Lines 7624 7648 +24
==========================================
+ Hits 7263 7298 +35
+ Misses 361 350 -11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4addedc to
bb65a9a
Compare
bendichter
reviewed
May 19, 2026
| @@ -0,0 +1,17 @@ | |||
| function validateUniqueColnames(colnames) | |||
Contributor
There was a problem hiding this comment.
It would be nice if you said which name was duplicated
bendichter
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Following PR #818,
DynamicTablevalidation now detects two metadata problems that can appear in existing NWB files: materialized columns missing fromcolnames, and duplicate entries incolnames.Those checks are useful when creating or exporting new data, but applying them as hard errors while reading existing files breaks compatibility with files that were previously readable. This change makes parsed file reads permissive for these
DynamicTablecolumn-name issues while keeping user-side construction and export strict.The implementation adds a generic validation context for read-time object construction, so this behavior can also support the broader read-validation policy discussed in related issue #776.
How to test the behavior?
Reading/parsing legacy DynamicTable metadata warns instead of failing.
Before:
After:
Creating new invalid DynamicTable metadata remains strict.
Before/After:
Improve error/warning message on unique column validation
Before:
After:
Checklist
fix #XXwhereXXis the issue number?