Fix multiple client and server lint/test bugs#98
Conversation
- Refactored `ChatToggleButton.tsx` to lazily initialize state instead of mutating within a `useEffect`, fixing a React lint warning. - Removed test exclusion in `server/tsconfig.json` to allow ESLint to properly parse `.test.ts` files without throwing resolution errors. - Fixed an `originalUrl` fallback bug in `errorHandler.test.ts`. - Implemented previously dangling test cases in `embeddings.test.ts`. - Adjusted a regex in `content-extractors.ts` to properly trim trailing spaces around new lines for Docx extraction and fixed matching test assertions. - Fixed other various typing problems and formatting issues caught by ESLint and Vitest.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
1 participant
The codebase contained several lint warnings and failing test scenarios. This commit resolves:
react-hooks/set-state-in-effectrule violation in the client by removing an unnecessaryuseEffectand correctly passing a lazy initializer touseState.@typescript-eslint/parsererrors on server test files by removing the**/*.test.tsexclusion inserver/tsconfig.json.embeddings.test.tsthat were causing syntax errors, moving them to a properitblock.errorHandler.test.tsforreq.originalUrl..docxparsing regex incontent-extractors.tsand its resulting Vitest failure incontent-extractors.test.ts.anyor malformed catches to strictly typed types, satisfying strict ESLint checks.PR created automatically by Jules for task 4281398120361291047 started by @Gautam7352