xdc to Core#548
Draft
stdevMac wants to merge 2 commits into
Draft
Conversation
Splits XDC into mainnet (xdc) and testnet (xdc-testnet) variants following the joc-mainnet/joc-testnet convention, so the EL container is launched with --config=xdc-testnet matching Nethermind's xdc-testnet.json chainspec (vs the previous NETWORK=xdc which silently booted the mainnet chain). Flips SupportsMEVBoost on NetworkXdc to true to mirror the other POA entries (validatePOANetwork strips MEV anyway). End-to-end sync verified against nethermindeth/nethermind:master for both variants.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes | Closes | Resolves #
Changes:
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that applyTesting
Requires testing
In case you checked yes, did you write tests?
Comments about testing , should you have some (optional)
Further comments (optional)
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...