feat: support split L2 HTTP and WebSocket RPC - #988
Draft
davidtaikocha wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧩 What was the bug?
Catalyst currently uses
L2_RPC_URLfor both ordinary execution-layer JSON-RPC requests and the chain monitor block subscription. Becauseeth_subscriberequires WebSocket, this forces ordinary request providers onto the same WebSocket transport. After that WebSocket backend exhausts its reconnect budget, ordinary requests can remain unavailable until Catalyst rebuilds the node/provider.Related rollout work:
🔧 What has been fixed?
L2_WS_RPC_URLfor the L2 block subscription.L2_RPC_URLfor ordinary L2 execution-layer requests, allowing those providers to use HTTP.L2_RPC_URLis alreadyws://orwss://, Catalyst reuses it ifL2_WS_RPC_URLis unset.L2_RPC_URLhas no WebSocket subscription URL, or when explicitL2_WS_RPC_URLis not WS/WSS.l2_ws_rpc_url; Pacaya and all execution-layer providers remain onl2_rpc_url.Example split configuration:
💬 Anything else reviewers should know?
This change does not remove the WebSocket subscription or change its reconnect policy. Deployment configuration must provide
L2_WS_RPC_URLbefore switchingL2_RPC_URLto HTTP.Validation completed locally:
cargo test --workspace --verbosecargo test -p common config::tests -- --nocapturecargo check -p shasta -p realtime -p pacayacargo sort --workspace --checkcargo fmt --all -- --checktyposcargo clippy --all-features -- -D warningscargo deny checkalso ran with the CI version of cargo-deny. It reports existing advisories in the unchangedCargo.lock(anyhow,crossbeam-epoch,ruint, and yankedspin); this PR does not modify dependencies.✅ Checklist
bugfix/<name>