Experiment: Support intel xpu device for the model side of things - #125
Draft
akaIDIOT wants to merge 6 commits into
Draft
Experiment: Support intel xpu device for the model side of things#125akaIDIOT wants to merge 6 commits into
akaIDIOT wants to merge 6 commits into
Conversation
akaIDIOT
commented
Aug 13, 2026
Comment on lines
+14
to
+19
| if torch.cuda.is_available(): | ||
| return torch.device('cuda') | ||
| if torch.xpu.is_available(): | ||
| return torch.device('xpu') | ||
| if torch.mps.is_available(): | ||
| return torch.device('mps') |
Member
Author
There was a problem hiding this comment.
This is wider than it really needs to be, but it might just work on macos now too.
Comment on lines
+28
to
+30
| if device.type == 'xpu': | ||
| # SPDA might cause runtime errors on xpu, default to eager attention to avoid it | ||
| model_args.setdefault('attn_implementation', 'eager') |
Member
Author
There was a problem hiding this comment.
When all seemed fine, the loaded model would raise a RuntimeError: could not create a primitive from transformers/integrations/sdpa_attention.py, clanker suggested setting the attention implementation to eager, which actually dodged the error and made the embedder tests succeed 🙏🏻
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.