Require exact chunked final Transfer-Encoding coding - #2223
Merged
Merged
Conversation
tappenzeller
marked this pull request as ready for review
September 24, 2026 15:16
tappenzeller
requested review from
AlexanderEllis,
argha-c,
fool1280,
gavinbunney,
ilanachalom,
jguerra,
lindseyreynolds and
matthoffman
as code owners
September 24, 2026 15:16
tappenzeller
force-pushed
the
normalize-transfer-encoding-parameters
branch
from
September 25, 2026 15:31
5465229 to
c977c7c
Compare
tappenzeller
changed the title
jguerra
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Http1FramingEnforcingHandler previously ignored transfer-coding parameters when checking the final item, so a value such as "chunked; mode=stream" was accepted as chunked.
RFC 9112 requires chunked to be the final transfer coding. Chunk extensions belong to the individual chunk syntax, not to the Transfer-Encoding header. This change therefore requires the final coding to be exactly chunked, compared case-insensitively after ordinary whitespace trimming. Parameters on earlier transfer codings remain supported, and accepted headers pass through unchanged.
Tests cover rejection of a parameterized final chunked coding and acceptance of a parameterized non-final coding followed by exact chunked.