This repository was archived by the owner on Sep 3, 2025. It is now read-only.
[WIP] fix: resolution notes markdown#6041
Closed
mvilanova wants to merge 2 commits into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR standardizes ValidationError usage across several get_by_name_or_raise functions, cleans up formatting (imports, trailing commas, blank lines), fixes a typo in the Dockerfile comment, and updates pre-commit hook configurations.
- Normalize how
ValidationErroris raised in source/query services - Refactor multi-line imports and trailing commas for consistency
- Bump pre-commit hook versions and refine their settings
Reviewed Changes
Copilot reviewed 103 out of 103 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/dispatch/data/source/transport/service.py | Reformatted raise ValidationError call |
| src/dispatch/data/source/status/service.py | Reformatted raise ValidationError call |
| src/dispatch/data/source/service.py | Reformatted raise ValidationError call |
| src/dispatch/data/source/environment/service.py | Reformatted raise ValidationError call |
| src/dispatch/data/source/data_format/service.py | Reformatted raise ValidationError call |
| src/dispatch/data/query/service.py | Reformatted raise ValidationError call |
| src/dispatch/data/alert/service.py | Removed stray hyphen |
| src/dispatch/conversation/models.py | Added blank lines for readability |
| src/dispatch/conference/service.py | Removed stray hyphen |
| src/dispatch/case_cost_type/service.py | Flattened function signatures |
| src/dispatch/case/views.py | Expanded imports into multi-line form and added blank line |
| src/dispatch/case/type/models.py | Added blank lines around Pydantic models |
| src/dispatch/case/service.py | Merged multi-line f-strings into one |
| src/dispatch/case/models.py | Added blank lines around pagination classes |
| src/dispatch/case/messaging.py | Added trailing comma to dict literal |
| src/dispatch/case/flows.py | Added trailing comma in import list |
| src/dispatch/auth/service.py | Reformatted model_dump call with trailing comma |
| docker/Dockerfile | Corrected typo from “directoy” to “directory” |
| .pre-commit-config.yaml | Upgraded hook versions and refined hook configurations |
| .coveragerc | Removed stray dash at end of file |
Comments suppressed due to low confidence (2)
src/dispatch/data/source/environment/service.py:46
- [nitpick] The
lockey is set to 'source' but this error refers to the source_environment; consider using ('source_environment',) for clearer error location.
"loc": ("source",),
src/dispatch/data/source/data_format/service.py:44
- [nitpick] The
lockey uses camelCase 'dataFormat'; consider aligning with snake_case field names (e.g. 'data_format') to match project conventions.
"loc": ("dataFormat",),
Contributor
|
This PR is stale, because it has been open for 45 days with no activity. Remove the stale label or comment, or this will be closed in 10 days. |
Contributor
|
This PR was closed, because it has been stalled for 10 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.