This repository was archived by the owner on Sep 3, 2025. It is now read-only.
fix: signal transaction management#6003
Merged
1 commit merged intoMay 21, 2025
Merged
Conversation
ghost
self-assigned this
whitdog47
approved these changes
May 21, 2025
ghost
merged commit
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed transaction error by removing commit from service function and adding it to the api view. removed redundant signal assignment in create_signal_instance. this prevents "can't operate on closed transaction" errors when called from nested transaction contexts while ensuring transactions are still committed when called from api endpoints.