Skip to content
This repository was archived by the owner on Sep 3, 2025. It is now read-only.

fix(slack): values must be str type#6001

Merged
whitdog47 merged 1 commit into
mainfrom
fix/tag-multi-select-as-str
May 20, 2025
Merged

fix(slack): values must be str type#6001
whitdog47 merged 1 commit into
mainfrom
fix/tag-multi-select-as-str

Conversation

@whitdog47

@whitdog47 whitdog47 commented May 20, 2025

Copy link
Copy Markdown
Contributor

This PR fixes the Slack integration for incident updates by ensuring that tag IDs are provided as strings in the interactive message options.

@whitdog47 whitdog47 requested review from a user and Copilot May 20, 2025 23:23
@whitdog47 whitdog47 self-assigned this May 20, 2025
@whitdog47 whitdog47 added the bug Something isn't working label May 20, 2025

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the Slack integration for incident updates by ensuring that tag IDs are provided as strings in the interactive message options.

  • Convert tag IDs to strings to comply with Slack's requirement for the "value" field.
  • Simplify type consistency in the interactive command handler.

Comment thread src/dispatch/plugins/dispatch_slack/incident/interactive.py
@whitdog47 whitdog47 merged commit 94f7167 into main May 20, 2025
11 checks passed
@whitdog47 whitdog47 deleted the fix/tag-multi-select-as-str branch May 20, 2025 23:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants