This repository was archived by the owner on Sep 3, 2025. It is now read-only.
fix(oncall service): return correct message if we encounter an integr…#5988
Merged
Conversation
…ity error on delete
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request updates error messages in the oncall service views to provide more descriptive and context-specific feedback when operations fail, particularly focusing on handling integrity errors during deletion.
- Updated error messages to reference "oncall service" instead of a generic "service".
- Reordered imports and updated the imported functions list.
Comments suppressed due to low confidence (1)
src/dispatch/service/views.py:8
- The 'delete' function is used in the delete_service function (line 117) but is no longer imported from .service. Please add 'delete' to the import list to ensure deletion works as expected.
from .service import ( get, get_all_by_external_ids, get_by_external_id_and_project_name, update, )
whitdog47
approved these changes
May 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ity error on delete