This repository was archived by the owner on Sep 3, 2025. It is now read-only.
fix(plugin): fixes plugin configuration not loading#5986
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where plugin configuration fails to load by migrating from the deprecated Pydantic 1 encoder to the new JSON encoding approach in Pydantic 2. The key changes include:
- Updating the configuration serialization in plugin models using json.dumps with model_dump.
- Adding logic in the Formkit conversion to handle json_schema anyOf conditions.
- Adjusting type annotations in plugin and individual models for better compatibility with Pydantic 2.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/dispatch/static/dispatch/src/plugin/store.js | Added logic to extract type and format from anyOf within json_schema properties |
| src/dispatch/plugin/models.py | Updated configuration serialization and adjusted type annotations for configuration_schema and configuration |
| src/dispatch/individual/models.py | Reorganized import formatting and modified id field typing in Pydantic models |
Comments suppressed due to low confidence (2)
src/dispatch/plugin/models.py:154
- Verify that using json.dumps with model_dump and the custom encoder produces the same expected serialization output for SecretStr fields as the previous pydantic .json() method.
self._configuration = json.dumps(
config_object.model_dump(), default=show_secrets_encoder
)
src/dispatch/individual/models.py:116
- The 'id' field in the read model is now optional; confirm that this change aligns with downstream consumers' expectations and does not inadvertently allow null values where an id is required.
id: PrimaryKey | None = None
ghost
approved these changes
May 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where plugin configuration fails to load by migrating from the deprecated Pydantic 1 encoder to the new JSON encoding approach in Pydantic 2. The key changes include: