This repository was archived by the owner on Sep 3, 2025. It is now read-only.
fix(case): more explicit None defaults#5982
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR aims to make None defaults and type conversions more explicit.
- In interactive.py, explicit int() conversions are introduced for project and entity identifier fields.
- In the case severity and priority models, explicit default values (i.e. “= None”) have been added for optional fields.
- In the case models, explicit defaults have been set for multiple fields to improve clarity and consistency.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/dispatch/plugins/dispatch_slack/case/interactive.py | Added explicit int() conversions for project and engagement IDs as well as entity ids. |
| src/dispatch/case/severity/models.py | Set explicit default values for optional fields in Pydantic models. |
| src/dispatch/case/priority/models.py | Assigned explicit defaults for optional fields and formatted the default_listener_doc for clarity. |
| src/dispatch/case/models.py | Introduced explicit default assignments for optional fields in various Pydantic models. |
ghost
approved these changes
May 17, 2025
|
I'm assuming anything that was Does this get all of them? |
Contributor
Author
|
@wssheldon turns out there were 31 more files that needed it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR continues the previousl efforts to make None defaults and type conversions more explicit.