Skip to content
This repository was archived by the owner on Sep 3, 2025. It is now read-only.

fix(slack): convert ids back from string to int#5981

Merged
whitdog47 merged 1 commit into
mainfrom
fix/ids-should-be-int
May 16, 2025
Merged

fix(slack): convert ids back from string to int#5981
whitdog47 merged 1 commit into
mainfrom
fix/ids-should-be-int

Conversation

@whitdog47

@whitdog47 whitdog47 commented May 16, 2025

Copy link
Copy Markdown
Contributor

This PR converts various IDs from strings back to integers for Slack-related incident and case interactions.

Convert project, incident, case, and other ID values using int() to ensure proper type handling.
Applies similar changes across both incident and case interactive modules.

@whitdog47 whitdog47 requested review from a user and Copilot May 16, 2025 23:18
@whitdog47 whitdog47 self-assigned this May 16, 2025
@whitdog47 whitdog47 added the bug Something isn't working label May 16, 2025

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR converts various IDs from strings back to integers for Slack-related incident and case interactions.

  • Convert project, incident, case, and other ID values using int() to ensure proper type handling.
  • Applies similar changes across both incident and case interactive modules.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/dispatch/plugins/dispatch_slack/incident/interactive.py Wraps multiple context ID accesses with int() conversions for incident flows.
src/dispatch/plugins/dispatch_slack/case/interactive.py Applies int() conversion for case IDs and project IDs to restore type consistency.

Comment thread src/dispatch/plugins/dispatch_slack/incident/interactive.py
Comment thread src/dispatch/plugins/dispatch_slack/case/interactive.py
@whitdog47 whitdog47 merged commit 1928cef into main May 16, 2025
11 checks passed
@whitdog47 whitdog47 deleted the fix/ids-should-be-int branch May 16, 2025 23:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants