This repository was archived by the owner on Sep 3, 2025. It is now read-only.
fix(slack): allow subject.id to be a number#5976
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Slack payload model to accept numeric subject IDs by enabling Pydantic’s coercion of numbers to strings.
- Imported
ConfigDictfrom Pydantic. - Added
model_configonSubjectMetadatato coerce numeric IDs to strings.
Comments suppressed due to low confidence (2)
src/dispatch/plugins/dispatch_slack/models.py:41
- No tests were added to verify that numeric subject IDs are correctly coerced to strings. Consider adding unit tests that pass numeric ID values to this model and validate that they become strings.
coerce_numbers_to_str=True
src/dispatch/plugins/dispatch_slack/models.py:37
- The class docstring for
SubjectMetadatadoesn’t mention the new coercion behavior. Please update the docstring to explain that numeric IDs will be accepted and coerced to strings.
class SubjectMetadata(BaseModel):
ghost
approved these changes
May 16, 2025
mvilanova
approved these changes
May 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the Slack payload model to accept numeric subject IDs by enabling Pydantic’s coercion of numbers to strings.