This repository was archived by the owner on Sep 3, 2025. It is now read-only.
feat(ui): adds ability to filter out selected case types#5939
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds UI functionality to filter out selected case types and updates the filtering logic on the backend to handle a new NotCaseType filter.
- Updates CaseCostCard.vue to use optional chaining for safe access.
- Refactors TableFilterDialog.vue to introduce a switch for include/exclude modes for case types.
- Extends service.py to support NotCaseType filtering in query specifications.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/dispatch/static/dispatch/src/case_cost/CaseCostCard.vue | Uses optional chaining to safeguard property access. |
| src/dispatch/static/dispatch/src/case/TableFilterDialog.vue | Adds new UI elements and computed properties to enable include/exclude filter modes. |
| src/dispatch/database/service.py | Introduces NotCaseType support and updates filtering functions accordingly. |
Comments suppressed due to low confidence (1)
src/dispatch/static/dispatch/src/case/TableFilterDialog.vue:123
- [nitpick] Consider renaming 'local_case_type' to 'included_case_types' to more clearly reflect that it holds case types when exclude mode is off.
const local_case_type = computed(() => (!exclude_mode.value ? local_selected_case_types.value : []))
mvilanova
approved these changes
Apr 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows for filtering out selected cases type(s).