Skip to content
This repository was archived by the owner on Sep 3, 2025. It is now read-only.

feat(ui): adds ability to filter out selected case types#5939

Merged
whitdog47 merged 3 commits into
mainfrom
feat/filter-by-not-case-type
Apr 29, 2025
Merged

feat(ui): adds ability to filter out selected case types#5939
whitdog47 merged 3 commits into
mainfrom
feat/filter-by-not-case-type

Conversation

@whitdog47

Copy link
Copy Markdown
Contributor

Allows for filtering out selected cases type(s).

image

@whitdog47 whitdog47 added the enhancement New feature or request label Apr 29, 2025
@whitdog47 whitdog47 requested review from Copilot and mvilanova April 29, 2025 18:01
@whitdog47 whitdog47 self-assigned this Apr 29, 2025

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds UI functionality to filter out selected case types and updates the filtering logic on the backend to handle a new NotCaseType filter.

  • Updates CaseCostCard.vue to use optional chaining for safe access.
  • Refactors TableFilterDialog.vue to introduce a switch for include/exclude modes for case types.
  • Extends service.py to support NotCaseType filtering in query specifications.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/dispatch/static/dispatch/src/case_cost/CaseCostCard.vue Uses optional chaining to safeguard property access.
src/dispatch/static/dispatch/src/case/TableFilterDialog.vue Adds new UI elements and computed properties to enable include/exclude filter modes.
src/dispatch/database/service.py Introduces NotCaseType support and updates filtering functions accordingly.
Comments suppressed due to low confidence (1)

src/dispatch/static/dispatch/src/case/TableFilterDialog.vue:123

  • [nitpick] Consider renaming 'local_case_type' to 'included_case_types' to more clearly reflect that it holds case types when exclude mode is off.
const local_case_type = computed(() => (!exclude_mode.value ? local_selected_case_types.value : []))

Comment thread src/dispatch/database/service.py
@whitdog47 whitdog47 merged commit ce72a3c into main Apr 29, 2025
9 checks passed
@whitdog47 whitdog47 deleted the feat/filter-by-not-case-type branch April 29, 2025 23:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants