This repository was archived by the owner on Sep 3, 2025. It is now read-only.
fix: allow GET on incidents/cases to include participants & other fields#5935
Merged
Conversation
|
Does that resolve the issue? If so, would @router.get("", summary="Retrieve a list of incidents.")
def get_incidents(
common: CommonParameters,
include: List[str] = Query([], alias="include[]"),
expand: bool = Query(default=False),
):
"""Retrieves a list of incidents."""
pagination = search_filter_sort_paginate(model="Incident", **common)
if expand:
return json.loads(IncidentExpandedPagination(**pagination).json())
if include:
# only allow two levels for now
include_sets = create_pydantic_include(include)
include_fields = {
"items": {"__all__": include_sets},
"itemsPerPage": ...,
"page": ...,
"total": ...,
}
return json.loads(IncidentPagination(**pagination).json(include=include_fields))
return json.loads(IncidentPagination(**pagination).json()) |
ghost
approved these changes
Apr 28, 2025
ghost
left a comment
There was a problem hiding this comment.
Regardless, I do think we want this change.
Contributor
Author
|
Good catch - I validated that incidents also don't support all fields and have updated it to use IncidentExpandedPagination |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A user reported that
include[]=participantshasn't been working for a few months. We currently are using theCasePaginationforget_casesbut I think we should useCaseExpandedPaginationto support allinclude[]options.