Skip to content

test(e2e): wait for the input row to hide under a pending permission prompt #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NetDevAutomate merged 1 commit into from
Sep 7, 2026
Merged

test(e2e): wait for the input row to hide under a pending permission prompt #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 17 additions & 11 deletions packages/studyloop/tests/test_web_acp_chat_ui.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
pytest.importorskip("playwright")
pytest.importorskip("fastapi")
pytest.importorskip("uvicorn")
from playwright.sync_api import TimeoutError as PlaywrightTimeoutError

_tests_dir = Path(__file__).parent
if str(_tests_dir) not in sys.path:
Expand Down Expand Up @@ -1982,17 +1983,22 @@ def test_allow_deny_buttons_render_and_input_row_hidden(
assert "Allow" in names and "Deny" in names, (
f"Expected Allow+Deny buttons, got: {names}"
)
# Input row must be hidden while prompt is pending.
input_row_visible = page.evaluate(
"""() => {
const r = document.querySelector('.acp-input-row');
if (!r) return false;
return getComputedStyle(r).display !== 'none';
}"""
)
assert not input_row_visible, (
"Input row should be hidden while permission prompt is pending"
)
# Input row must be hidden while prompt is pending. The prompt is
# attached first and Alpine applies the x-show style on the next
# tick, so wait for the hidden state instead of sampling it once
# (a one-shot evaluate raced this on a loaded CI runner).
try:
page.wait_for_function(
"""() => {
const r = document.querySelector('.acp-input-row');
return !r || getComputedStyle(r).display === 'none';
}""",
timeout=3000,
)
except PlaywrightTimeoutError:
raise AssertionError(
"Input row should be hidden while permission prompt is pending"
) from None

filtered_errors = [
e for e in app_errors if "Cannot read properties of null (reading 'type')" not in e
Expand Down