fix: handle fc host in eseries#4294
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the E-Series hardware host-interface collector to correctly parse Fibre Channel (FC) interface payloads where the interfaceType enum value doesn’t match the JSON property key, and where FC uses different field names for link/speed. Also updates the Grafana dashboard to display interface type and adds unit coverage for the new parsing paths.
Changes:
- Add
interfaceTypeToDataKeyto mapinterfaceType→ correctioInterfaceTypeDataJSON key (e.g.,fc→fibre). - Add FC-aware fallbacks for link and speed fields (
linkStatus/currentInterfaceSpeed). - Update the E-Series hardware Grafana table to show
interface_type, and add targeted tests for host-interface parsing.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| grafana/dashboards/eseries/hardware.json | Stops excluding interface_type so the Host Interfaces table shows port type. |
| cmd/collectors/eseries/plugins/hardware/controller.go | Fixes host-interface parsing for FC and key-mismatch interface types; adds field fallbacks for FC. |
| cmd/collectors/eseries/plugins/hardware/controller_test.go | Adds tests covering FC parsing, key mapping, and label correctness. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Hardikl
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.