Refactor Skill API endpoints - #84
Merged
Merged
Conversation
Includes updates to unit tests to account for refactor
NeonDaniel
marked this pull request as ready for review
August 20, 2025 21:15
Merged
NeonDaniel
added a commit
that referenced
this pull request
Jul 7, 2026
* Refactor into a structure that supports editable installation (#83) * Refactor into a structure that supports editable installation * Fix resource file path in setup.py * Update skill tests to prevent legacy skill loading * Skip failing OVOS intent tests * Comment out occasionally failing test case * Try re-enabling OVOS Intent tests with updated `neon-minerva` * Fix typo in neon-minerva test extra deps * Update neon-minerva test dependency * Increment Version to 1.1.2a1 * Refactor Skill API endpoints (#84) * Refactor Skill API endpoints to use Pydantic models Includes updates to unit tests to account for refactor * Update skill.json * Update tests to account for API changes * Implement new API methods for current timestamp and parsed date information * Fix syntax error in added Response model --------- Co-authored-by: NeonDaniel <NeonDaniel@users.noreply.github.com> * Increment Version to 1.1.2a2 * Refactor package name for consistency with other skills and plugins (#85) * Refactor package name from `skill_date_time` to `neon_skill_date_time` for consistency * Refactor references to old package name * Increment Version to 1.1.2a3 * Update test dependency to stable spec (#86) * Update test dependency to stable spec * Update skill.json --------- Co-authored-by: NeonDaniel <NeonDaniel@users.noreply.github.com> * Increment Version to 1.1.2a4 * Increment Version to 2.0.0 * Update Changelog --------- Co-authored-by: Daniel McKnight <34697904+NeonDaniel@users.noreply.github.com> Co-authored-by: NeonDaniel <NeonDaniel@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactors Skill API endpoints to accept and return Pydantic objects for schema documentation
Removes unused API kwargs for "message" and "anchor date"
Issues
Other Notes
Includes breaking changes, but known uses will not be impacted (i.e. homescreen)