Skip to content

Reset cuesheet doesnt reset audio player duration #600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NeoCoderMatrix86 merged 5 commits into from
Sep 23, 2026
Merged

Reset cuesheet doesnt reset audio player duration #600

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e936cda
Update AudioPlayer.razor
NeoCoderMatrix86 Sep 21, 2026
a9332ba
Update PlaybackService.cs
NeoCoderMatrix86 Sep 21, 2026
1b83d63
reset playback when application gets reset
NeoCoderMatrix86 Sep 21, 2026
f9616b5
Update PlaybackService.cs
NeoCoderMatrix86 Sep 23, 2026
9624198
fix audiofile reset bug
NeoCoderMatrix86 Sep 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
125 changes: 117 additions & 8 deletions AudioCuesheetEditor.Tests/Services/AudioCuesheet/AudiofileManagerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,14 @@ public async Task SetPropertiesAsync_EmptyBrowserFile_ShouldClearPropertiesAsync
ObjectURL = "Just a test",
Duration = TimeSpan.FromSeconds(120)
};
var audiofileChangedFired = false;
_audiofileManager.AudiofileChanged += delegate(object? sender, Audiofile e)
{
if (e == audiofile)
{
audiofileChangedFired = true;
}
};
var expectedUrl = audiofile.ObjectURL;
// Act
await _audiofileManager.SetPropertiesAsync(audiofile, null, string.Empty);
Expand All @@ -96,6 +104,7 @@ public async Task SetPropertiesAsync_EmptyBrowserFile_ShouldClearPropertiesAsync
Assert.IsNull(audiofile.Name);
Assert.IsNull(audiofile.ObjectURL);
Assert.IsNull(audiofile.Duration);
Assert.IsTrue(audiofileChangedFired);
_jsRuntime.Verify(js => js.InvokeAsync<object>("revokeAudioObjectURL", It.Is<object?[]>(args => args != null && args.Length > 0 && (args[0] as string) == expectedUrl)), Times.Once);
}

Expand All @@ -116,7 +125,14 @@ public async Task SetPropertiesAsync_WithBrowserFile_ShouldSetPropertiesAsync()
_jsRuntime.Setup(js => js.InvokeAsync<double>("getAudioDurationFromFile", It.IsAny<object?[]>())).Returns(new ValueTask<double>(90.0));

var audiofile = new Audiofile();

var audiofileChangedFired = false;
_audiofileManager.AudiofileChanged += delegate (object? sender, Audiofile e)
{
if (e == audiofile)
{
audiofileChangedFired = true;
}
};
// Act
await _audiofileManager.SetPropertiesAsync(audiofile, browserFile.Object, inputId);

Expand All @@ -125,7 +141,7 @@ public async Task SetPropertiesAsync_WithBrowserFile_ShouldSetPropertiesAsync()
Assert.AreEqual(filename, audiofile.Name);
Assert.AreEqual(objectUrl, audiofile.ObjectURL);
Assert.AreEqual(TimeSpan.FromSeconds(90), audiofile.Duration);

Assert.IsTrue(audiofileChangedFired);
_fileInputManager.Verify(f => f.GetAudioCodec("audio/mpeg", filename), Times.Once);
_fileInputManager.Verify(f => f.GetObjectUrlAsync(inputId), Times.Once);
_jsRuntime.Verify(js => js.InvokeAsync<double>("getAudioDurationFromFile", It.Is<object?[]>(o => o[0] as string == audiofile.ObjectURL)), Times.Once);
Expand Down Expand Up @@ -161,7 +177,14 @@ public async Task SetProperty_AudiofileWithDuration_SetsLastTrackEndAlsoAsync()
{
Tracks = [track1, track2]
};

var audiofileChangedFired = false;
_audiofileManager.AudiofileChanged += delegate (object? sender, Audiofile e)
{
if (e == audiofile)
{
audiofileChangedFired = true;
}
};
// Act
await _audiofileManager.SetPropertiesAsync(audiofile, browserFile.Object, inputId);

Expand All @@ -171,7 +194,7 @@ public async Task SetProperty_AudiofileWithDuration_SetsLastTrackEndAlsoAsync()
Assert.AreEqual(objectUrl, audiofile.ObjectURL);
Assert.AreEqual(TimeSpan.FromSeconds(90), audiofile.Duration);
Assert.AreEqual(TimeSpan.FromSeconds(90), track2.End);

Assert.IsTrue(audiofileChangedFired);
_fileInputManager.Verify(f => f.GetAudioCodec("audio/mpeg", filename), Times.Once);
_fileInputManager.Verify(f => f.GetObjectUrlAsync(inputId), Times.Once);
_jsRuntime.Verify(js => js.InvokeAsync<double>("getAudioDurationFromFile", It.Is<object?[]>(o => o[0] as string == audiofile.ObjectURL)), Times.Once);
Expand All @@ -186,11 +209,19 @@ public async Task SetPropertiesAsync_NullBrowserFile_WithExistingObjectUrl_Shoul
ObjectURL = "just a test"
};
var expectedUrl = audiofile.ObjectURL;

var audiofileChangedFired = false;
_audiofileManager.AudiofileChanged += delegate (object? sender, Audiofile e)
{
if (e == audiofile)
{
audiofileChangedFired = true;
}
};
// Act
await _audiofileManager.SetPropertiesAsync(audiofile, null, string.Empty);

// Assert
Assert.IsTrue(audiofileChangedFired);
_jsRuntime.Verify(js =>js.InvokeAsync<object>("revokeAudioObjectURL", It.Is<object?[]>(args => args != null && args.Length > 0 && (args[0] as string) == expectedUrl)),Times.Once);
Assert.IsNull(audiofile.ObjectURL);
}
Expand All @@ -203,12 +234,20 @@ public void SetProperty_ChangedName_UpdatesPropertyAndAddsTrace()
{
Name = "oldname.mp3"
};

var audiofileChangedFired = false;
_audiofileManager.AudiofileChanged += delegate (object? sender, Audiofile e)
{
if (e == audiofile)
{
audiofileChangedFired = true;
}
};
// Act
_audiofileManager.SetProperty(audiofile, x => x.Name, "newname.mp3");

// Assert
Assert.AreEqual("newname.mp3", audiofile.Name);
Assert.IsTrue(audiofileChangedFired);
_traceChangeManager.Verify(x => x.AddChange(It.Is<TracedChange>(y => y.TraceableObject == audiofile && y.TraceableChange.PreviousValue!.Equals("oldname.mp3") && y.TraceableChange.PropertyName == nameof(Audiofile.Name))), Times.Once);
}

Expand All @@ -220,11 +259,19 @@ public void SetProperty_EqualValue_DoesntChangeProperty()
{
Name = "oldname.mp3"
};

var audiofileChangedFired = false;
_audiofileManager.AudiofileChanged += delegate (object? sender, Audiofile e)
{
if (e == audiofile)
{
audiofileChangedFired = true;
}
};
// Act
_audiofileManager.SetProperty(audiofile, x => x.Name, "oldname.mp3");

// Assert
Assert.IsFalse(audiofileChangedFired);
_traceChangeManager.Verify(x => x.AddChange(It.Is<TracedChange>(y => y.TraceableObject == audiofile && y.TraceableChange.PreviousValue!.Equals("oldname.mp3") && y.TraceableChange.PropertyName == nameof(Audiofile.Name))), Times.Never);
}

Expand All @@ -248,13 +295,21 @@ public void SetProperty_DurationChanged_SetsLastTrackEndAlso()
Tracks = [track1, track2],
};
var duration = new TimeSpan(0, 3, 37, 12);

var audiofileChangedFired = false;
_audiofileManager.AudiofileChanged += delegate (object? sender, Audiofile e)
{
if (e == audiofile)
{
audiofileChangedFired = true;
}
};
// Act
_audiofileManager.SetProperty(audiofile, x => x.Duration, duration);

// Assert
Assert.AreEqual(duration, audiofile.Duration);
Assert.AreEqual(duration, track2.End);
Assert.IsTrue(audiofileChangedFired);
}

[TestMethod]
Expand All @@ -268,11 +323,20 @@ public void AddTrack_FirstTrack_AddsNewTrackWithCalulatedTrackProperties()
Audiofiles = [audiofile]
};
_sessionStateContainer.Setup(x => x.ActiveCuesheet).Returns(cuesheet);
var audiofileChangedFired = false;
_audiofileManager.AudiofileChanged += delegate (object? sender, Audiofile e)
{
if (e == audiofile)
{
audiofileChangedFired = true;
}
};
var track = new Track();
// Act
_audiofileManager.AddTrack(audiofile, track);
// Assert
Assert.HasCount(1, audiofile.Tracks);
Assert.IsTrue(audiofileChangedFired);
Assert.AreEqual((ushort)1, audiofile.Tracks.First().Position);
Assert.AreEqual(TimeSpan.Zero, audiofile.Tracks.First().Begin);
Assert.AreEqual(duration, audiofile.Tracks.First().End);
Expand Down Expand Up @@ -307,6 +371,14 @@ public void AddTrack_AddToPreviousTracks_AddsNewTrackWithCalulatedTrackPropertie
{
IsLinkedToPreviousTrack = true
};
var audiofileChangedFired = false;
_audiofileManager.AudiofileChanged += delegate (object? sender, Audiofile e)
{
if (e == audiofile)
{
audiofileChangedFired = true;
}
};
// Act
_audiofileManager.AddTrack(audiofile, track);
// Assert
Expand All @@ -316,6 +388,7 @@ public void AddTrack_AddToPreviousTracks_AddsNewTrackWithCalulatedTrackPropertie
Assert.AreEqual(duration, audiofile.Tracks.Last().End);
Assert.AreEqual(cuesheet, track.Cuesheet);
Assert.AreEqual(audiofile, track.Audiofile);
Assert.IsTrue(audiofileChangedFired);
_traceChangeManager.Verify(x => x.AddChange(It.Is<TracedChange>(y => y.TraceableObject == audiofile && y.TraceableChange.PreviousValue == tracks && y.TraceableChange.PropertyName == nameof(Audiofile.Tracks))), Times.Once);
_traceChangeManager.VerifySet(t => t.BulkEdit = true, Times.Once);
_traceChangeManager.VerifySet(t => t.BulkEdit = false, Times.Once);
Expand Down Expand Up @@ -348,9 +421,18 @@ public void AddTrack_DuringRecording_AddsNewTrackWithCalulatedTrackProperties()
{
IsLinkedToPreviousTrack = true
};
var audiofileChangedFired = false;
_audiofileManager.AudiofileChanged += delegate (object? sender, Audiofile e)
{
if (e == audiofile)
{
audiofileChangedFired = true;
}
};
// Act
_audiofileManager.AddTrack(audiofile, track);
// Assert
Assert.IsTrue(audiofileChangedFired);
Assert.HasCount(2, audiofile.Tracks);
Assert.AreEqual((ushort)2, audiofile.Tracks.Last().Position);
Assert.IsNotNull(audiofile.Tracks.First().End);
Expand All @@ -374,9 +456,18 @@ public void AddTrack_FirstTrackImporting_AddsNewTrackWithCalulatedTrackPropertie
};
_sessionStateContainer.Setup(x => x.ActiveCuesheet).Returns(importCuesheet);
var track = new Track();
var audiofileChangedFired = false;
_audiofileManager.AudiofileChanged += delegate (object? sender, Audiofile e)
{
if (e == audiofile)
{
audiofileChangedFired = true;
}
};
// Act
_audiofileManager.AddTrack(audiofile, track);
// Assert
Assert.IsTrue(audiofileChangedFired);
Assert.HasCount(1, audiofile.Tracks);
Assert.AreEqual((ushort)1, audiofile.Tracks.First().Position);
Assert.AreEqual(TimeSpan.Zero, audiofile.Tracks.First().Begin);
Expand Down Expand Up @@ -442,13 +533,22 @@ public void RemoveTracks_WithAttachedTracks_RemovesTracksAndRecalculatesRemainin
track4.Cuesheet = cuesheet;
track5.Cuesheet = cuesheet;
_sessionStateContainer.Setup(x => x.ActiveCuesheet).Returns(cuesheet);
var audiofileChangedFired = false;
_audiofileManager.AudiofileChanged += delegate (object? sender, Audiofile e)
{
if (e == audiofile)
{
audiofileChangedFired = true;
}
};
// Act
_audiofileManager.RemoveTracks(audiofile, [track2, track4]);
// Assert
Assert.HasCount(3, audiofile.Tracks);
Assert.Contains(track1, audiofile.Tracks);
Assert.Contains(track3, audiofile.Tracks);
Assert.Contains(track5, audiofile.Tracks);
Assert.IsTrue(audiofileChangedFired);
Assert.AreEqual((ushort)1, track1.Position);
Assert.AreEqual(TimeSpan.Zero, track1.Begin);
Assert.AreEqual(track1.End, track3.Begin);
Expand Down Expand Up @@ -520,6 +620,14 @@ public void RemoveTracks_DuringImport_RemovesTracksAndRecalculatesRemainingTrack
track4.Audiofile = audiofile;
track5.Audiofile = audiofile;
_sessionStateContainer.Setup(x => x.ActiveCuesheet).Returns(importCuesheet);
var audiofileChangedFired = false;
_audiofileManager.AudiofileChanged += delegate (object? sender, Audiofile e)
{
if (e == audiofile)
{
audiofileChangedFired = true;
}
};
// Act
_audiofileManager.RemoveTracks(audiofile, [track2, track4]);
// Assert
Expand All @@ -533,6 +641,7 @@ public void RemoveTracks_DuringImport_RemovesTracksAndRecalculatesRemainingTrack
Assert.AreEqual((ushort)2, track3.Position);
Assert.AreEqual(track5.Begin, track3.End);
Assert.AreEqual((ushort)3, track5.Position);
Assert.IsTrue(audiofileChangedFired);
Assert.AreEqual(duration, track5.End);
_traceChangeManager.Verify(x => x.AddChange(It.Is<TracedChange>(y => y.TraceableObject == audiofile && y.TraceableChange.PreviousValue == previousValue && y.TraceableChange.PropertyName == nameof(Audiofile.Tracks))), Times.Once);
_traceChangeManager.VerifySet(t => t.BulkEdit = true, Times.Once);
Expand Down
13 changes: 9 additions & 4 deletions AudioCuesheetEditor.Tests/Services/UI/SessionStateContainerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,14 +45,17 @@ public async Task Cuesheet_SetNewValueInDetailView_ShouldTriggerActiveCuesheetCh
var viewOptions = new ViewOptions();
_localStorageOptionsProvider.Setup(x => x.GetOptionsAsync<ViewOptions>()).ReturnsAsync(viewOptions);
await _sessionStateContainer.InitializeAsync();
bool eventTriggered = false;
_sessionStateContainer.ActiveCuesheetChanged += (sender, args) => eventTriggered = true;
bool activeCuesheetChangedEvent = false;
bool cuesheetChangedEvent = false;
_sessionStateContainer.ActiveCuesheetChanged += (sender, args) => activeCuesheetChangedEvent = true;
_sessionStateContainer.CuesheetChanged += (sender, args) => cuesheetChangedEvent = true;

// Act
_sessionStateContainer.Cuesheet = newCuesheet;

// Assert
Assert.IsTrue(eventTriggered);
Assert.IsTrue(activeCuesheetChangedEvent);
Assert.IsTrue(cuesheetChangedEvent);
}

[TestMethod]
Expand All @@ -67,13 +70,15 @@ public async Task Cuesheet_SetNewValueInImportView_ShouldNotTriggerActiveCueshee
_localStorageOptionsProvider.Setup(x => x.GetOptionsAsync<ViewOptions>()).ReturnsAsync(viewOptions);
await _sessionStateContainer.InitializeAsync();
bool eventTriggered = false;
bool cuesheetChangedEvent = false;
_sessionStateContainer.ActiveCuesheetChanged += (sender, args) => eventTriggered = true;

_sessionStateContainer.CuesheetChanged += (sender, args) => cuesheetChangedEvent = true;
// Act
_sessionStateContainer.Cuesheet = newCuesheet;

// Assert
Assert.IsFalse(eventTriggered);
Assert.IsTrue(cuesheetChangedEvent);
}

[TestMethod]
Expand Down
Loading
Loading