Skip to content

Update AbstractProtoMapper.java - #40

Open
NejlaSetkic wants to merge 1 commit into
mainfrom
NejlaSetkic-patch-41
Open

Update AbstractProtoMapper.java#40
NejlaSetkic wants to merge 1 commit into
mainfrom
NejlaSetkic-patch-41

Conversation

@NejlaSetkic

Copy link
Copy Markdown
Owner

Pull Request type

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes (Please run ./gradlew generateLock saveLock to refresh dependencies)
  • WHOSUSING.md
  • Other (please describe):

Changes in this PR

Describe the new behavior from this PR, and why it's needed
Issue #

Alternatives considered

Describe alternative implementation you have considered

@NejlaSetkic

Copy link
Copy Markdown
Owner Author

CodeScene PR Check


View detailed results in CodeScene

Quality Gates FAILED
Recommended Review Level Detailed -- This change violates your planned goals. Address the violation or revisit the goal in CodeScene.

Warnings

Degrades in Code Health

  • conductor/grpc/src/main/java/com/netflix/conductor/grpc/AbstractProtoMapper.java degrades from a Code Health of 4.82 -> 3.98

Violates Goals

  • Hotspots marked supervise, conductor/grpc/src/main/java/com/netflix/conductor/grpc/AbstractProtoMapper.java, degrades from a Code Health of 4.82 -> 3.98

Code Health Delta Descriptions

grpc/src/main/java/com/netflix/conductor/grpc/AbstractProtoMapper.java

Improvements

  • Complex Method : toProto is no longer above the threshold for cyclomatic complexity, toProto is no longer above the threshold for cyclomatic complexity, toProto is no longer above the threshold for cyclomatic complexity, toProto is no longer above the threshold for cyclomatic complexity, toProto is no longer above the threshold for cyclomatic complexity and 4 more functions. - getting better
  • Code Duplication - no longer an issue

Degradations

  • String Heavy Function Arguments : In this module, 45.0% of all arguments to its 54 functions are strings. The threshold for string arguments is 39.0% - new issue
  • Constructor Over-Injection : WorkflowExecutor has 10 arguments, threshold = 5 - new issue
  • Brain Method : rerunWF is a brain method - new issue
  • Excess Number of Function Arguments : startWorkflow has 5 arguments, threshold = 4, startWorkflow has 6 arguments, threshold = 4, startWorkflow has 6 arguments, threshold = 4, startWorkflow has 7 arguments, threshold = 4, startWorkflow has 7 arguments, threshold = 4 and 8 more functions. - new issue
  • Bumpy Road Ahead : rerunWF has 6 logical blocks with deeply nested code. Threshold is one single block per function, decide has 2 logical blocks with deeply nested code. Threshold is one single block per function, setTaskDomains has 2 logical blocks with deeply nested code. Threshold is one single block per function, scheduleTask has 2 logical blocks with deeply nested code. Threshold is one single block per function - new issue
  • Deep, Nested Complexity : rerunWF has a nested complexity depth of 4, threshold = 4 - new issue
  • Primitive Obsession : In this module, 59.2% of all function arguments are primitive types, threshold = 30.0% - new issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant