Skip to content

Self-serve GitHub disconnect with confirmation - #461

Merged
shanerbaner82 merged 1 commit into
mainfrom
feature/github-self-serve-disconnect
Aug 4, 2026
Merged

shanerbaner82 merged 1 commit into
mainfrom
feature/github-self-serve-disconnect

Conversation

@shanerbaner82

Copy link
Copy Markdown
Contributor

Summary

  • Adds a GitHub Account card to the Integrations page, visible to all users — previously the only Disconnect button lived inside the nativephp/mobile banner, which only renders for Max license holders, so plugin developers had no way to disconnect (see the support thread where a user couldn't re-authorize to grant org repo access).
  • Disconnect now goes through a Flux confirmation modal listing the consequences: private repo access (nativephp/mobile, nativephp/claude-code) revoked, plugin repo listing disabled, plus a reminder to grant organization access when re-authorizing. Users who sign in via GitHub with no password set get an extra warning to set one first.
  • GitHubIntegrationController::disconnect() now clears the cached collaborator statuses so the page reflects the disconnect immediately instead of after up to 5 minutes.
  • Removed the old one-click, no-confirmation Disconnect form from the mobile repo banner — the account card is the single disconnect path.

Test plan

  • php artisan test tests/Feature/GitHubIntegrationTest.php (14 passed, incl. 3 new tests: card visible without a license, disconnect option for connected users without a license, disconnect clears token + caches)
  • php artisan test tests/Feature/DiscordIntegrationTest.php (same page, 5 passed)
  • Pint clean

🤖 Generated with Claude Code

All users can now disconnect their GitHub account from the Integrations
page, not just Max license holders. The disconnect goes through a
confirmation modal that explains the consequences (private repo access
revoked, plugin repo listing disabled) and reminds users to grant org
access when re-authorizing. Disconnecting also clears the cached
collaborator statuses so the page reflects the change immediately.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@shanerbaner82
shanerbaner82 merged commit 3d9b888 into main Aug 4, 2026
3 checks passed
@shanerbaner82
shanerbaner82 deleted the feature/github-self-serve-disconnect branch August 4, 2026 20:36
SimonTingle pushed a commit to SimonTingle/nativephp.com that referenced this pull request Sep 19, 2026
…erve-disconnect

Self-serve GitHub disconnect with confirmation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant