Repository navigation
Use PNG compression level 6 for Android resources - #535
Open
PrestaEdit wants to merge 2 commits into
Open
PrestaEdit wants to merge 2 commits into
PrestaEdit wants to merge 2 commits into
Conversation
Contributor
|
Thanks for the numbers, that's a big build-time win. One small thing: the code comment right above the call in |
Contributor
Author
|
Done, updated the comment. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #399. When
android.image_formatispng(the default), launcher icons and splash screens are written withimagepng(..., 9). Level 9 is very slow for a tiny size gain over zlib's default level 6. PNG compression is lossless, so the output pixels are identical either way.Measured on a 1280×1920 xxxhdpi splash:
With up to 10 splash variants (5 densities × light/dark) plus icons, level 9 adds roughly a minute to every Android build for ~2% smaller files. The WebP path is unchanged.
Same level as the 3.x backport in #534.
tests/Unit/Concernspasses.🤖 Generated with Claude Code