Repository navigation
Conversation
In landscape the root renderers inset each screen by the Scaffold padding, so the strips beside the camera cutout and behind the navigation bar showed the Scaffold's default colour instead of the screen's own background. A shared screenBackground() modifier now paints the screen's flat background (bg-*, or its dark variant) behind that padding, in both the stack and the tabs renderer — iOS fills the safe areas with the screen background since NativePHP#477.
Member
|
How does it behave with backgrounds that have transparency e.g. |
simonhamp
approved these changes
Oct 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's wrong
On Android in landscape, a screen's background colour (
bg-*) doesn't reach the edges. The strip beside the camera and the strip behind the navigation buttons keep the app theme's colour instead. iOS already fills them with the screen's colour (#477).Why
Android shrinks the screen by those strips, and the space left behind shows the container's default colour.
What this does
The screen's background (
bg-*, or its dark-mode variant) is also painted behind those strips. Screens without a background don't change. It covers both layouts (normal and tabs) through one small helper. Android only.How to reproduce
Open this screen on Android and rotate to landscape.
Tested on an Android 16 emulator (stack layout).