Repository navigation
Pass the whole native payload to a lone array #[On] parameter - #508
Closed
ngunyimacharia wants to merge 1 commit into
Closed
ngunyimacharia wants to merge 1 commit into
ngunyimacharia wants to merge 1 commit into
Conversation
Contributor
Author
|
Superseded by #510, which does this explicitly through a typed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A native event listener like this crashes with
BindingResolutionException:Named binding looks for a payload key called
payload. It finds none, and the container can't resolve a barearray.Fix
When a listener has exactly one
arrayparameter and the payload has no key with that name, the listener gets the whole payload.A matching key still binds by name as before. So
onItems(array $items)with['items' => [...]]still gets just$items.Tests
tests/Feature/Edge/NativeEventPayloadBindingTest.phpcovers both cases.This works on its own and also merges cleanly with #505. Together they let nested components use this listener shape.