Skip to content

Allow x86_64 simulator builds for Intel Macs - #363

Merged
simonhamp merged 1 commit into
mainfrom
x86_64-sim-arch
Sep 20, 2026
Merged

simonhamp merged 1 commit into
mainfrom
x86_64-sim-arch

Conversation

@simonhamp

Copy link
Copy Markdown
Member

What

Removes EXCLUDED_ARCHS[sdk=iphonesimulator*] = x86_64 from both the Debug and Release build configurations in the bundled Xcode project.

Why

The exclusion forced simulator builds to arm64 only, so the app could not be built or run on the iOS Simulator on Intel Macs.

This pairs with the companion work in nativephp/php-bin-mobile that ships x86_64 simulator slices — now that the PHP runtime has an x86_64 simulator slice, there's no reason for the Xcode project to keep excluding that arch.

Notes

Apple Silicon builds are unaffected: Xcode still picks arm64 for the simulator there. On Intel Macs, the simulator now resolves to x86_64 instead of failing to find a valid architecture.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@simonhamp
simonhamp marked this pull request as ready for review September 20, 2026 00:45
@coderabbitai

coderabbitai Bot commented Sep 20, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 63342e02-64d7-4305-b6fe-37be3df96f49

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@simonhamp

Copy link
Copy Markdown
Member Author

Merging but this on its own won't allow builds to succeed on Intel Macs. We still need https://github.com/NativePHP/php-bin-mobile/pull/32 and #364 to be merged.

@simonhamp
simonhamp merged commit 1433d92 into main Sep 20, 2026
4 checks passed
@simonhamp
simonhamp deleted the x86_64-sim-arch branch September 20, 2026 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant