Repository navigation
Restore the zip error detail lost by the SuperNative squash - #276
Merged
simonhamp merged 1 commit intoAug 4, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up from the squash audit discussed in #217. When
zipfails during the iOS build, the exception currently reports a bareFailed to create ZIP filewith no indication of why (disk full, permissions, unreadable file). #138 added the underlying error to the message, but the SuperNative squash (#173) carried a pre-#138 copy ofcreateAppZip, silently reverting it.This restores the original behavior: zip's stderr first, stdout as fallback, exit code as last resort. Since this exception is the only thing a user sees when a build dies at the zip step, the detail is what turns an undiagnosable support thread into a self-solvable error.