Skip to content

Fast PCM Encoding#72

Open
FalconPDX wants to merge 2 commits into
NativeInstruments:masterfrom
FalconPDX:feature/fast_pcm_encoding
Open

Fast PCM Encoding#72
FalconPDX wants to merge 2 commits into
NativeInstruments:masterfrom
FalconPDX:feature/fast_pcm_encoding

Conversation

@FalconPDX

@FalconPDX FalconPDX commented Jan 14, 2024

Copy link
Copy Markdown
Collaborator

Uses the pcm library to encode a range instead of each element in a range. Makes encoding much faster.

This is a first of three different packages - starting off with the smallest. The other two (refactor of the ofstream interface + FLAC encoding) will come at a later time in the form of a "stacked PR". This gives users a chance to try out the individual pieces and potentially find issues quicker at the cost of repeated testing.

The other two PRs:
ofstream refactor: FalconPDX#3
FLAC encoding: FalconPDX#4

@FalconPDX FalconPDX added the ofstream ofstream improvements label Jan 14, 2024
@FalconPDX FalconPDX requested a review from ni-mheppner January 14, 2024 16:01
@FalconPDX FalconPDX self-assigned this Jan 14, 2024
@FalconPDX FalconPDX requested a review from ni-tsmit as a code owner January 14, 2024 16:01
@codecov

codecov Bot commented Jan 14, 2024

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.33333% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.00%. Comparing base (89eb1e3) to head (f10b034).
⚠️ Report is 14 commits behind head on master.

Files with missing lines Patch % Lines
audiostream/inc/ni/media/audio/ostream.h 83.33% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #72      +/-   ##
==========================================
- Coverage   83.10%   83.00%   -0.10%     
==========================================
  Files          82       82              
  Lines        2024     2030       +6     
==========================================
+ Hits         1682     1685       +3     
- Misses        342      345       +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ofstream ofstream improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant