Starting structure for OM refactor#92
Draft
elenya-grant wants to merge 38 commits into
Draft
Conversation
…olyzer into om_refactor/structure
…rolyzer into om_refactor/structure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting structure for OM refactor
This PR requires PR #90 to be merged in!
This PR introduces a different structure of the functionality within the electrolyzer repo to accommodate an Open-MDAO structure. This is in a somewhat intermediate state so that future development has smaller PRs and can have more rigorous testing and a focus on individual component development. This PR really focuses on the structure for the "cluster" and the connection from a cluster to a controller. The "controller" right now is just an
IndepVarCompbecause the structure is only set-up to handle one cluster at the moment. The cluster is comprised of 3 main subgroups:converter: perhaps this should be renamed to "pre_translator". This defines the current operational bounds and also is used to get curve coefficients for the power-to-current conversion.translator: this is used to take a cluster input power signal and convert it to the cell-level current inputsimulation: this takes the cell-level current input and simulates cell degradation, includes dynamic operating constraints, and simulates the cell performance.Plans for follow-on PRs:
Files to Remove (were helper/drafts):
electrolyzer/translators/power_translator_baseclass.pyelectrolyzer/core/simulate_structure.pyelectrolyzer/core/pre_processing_structure_v2.pyRelated issue, if one exists
Impacted areas of the software
Additional supporting information
Test results, if applicable