Skip to content

Starting structure for OM refactor#92

Draft
elenya-grant wants to merge 38 commits into
NatLabRockies:developfrom
elenya-grant:om_refactor/structure
Draft

Starting structure for OM refactor#92
elenya-grant wants to merge 38 commits into
NatLabRockies:developfrom
elenya-grant:om_refactor/structure

Conversation

@elenya-grant

@elenya-grant elenya-grant commented Jul 13, 2026

Copy link
Copy Markdown
Collaborator

Starting structure for OM refactor

This PR requires PR #90 to be merged in!

This PR introduces a different structure of the functionality within the electrolyzer repo to accommodate an Open-MDAO structure. This is in a somewhat intermediate state so that future development has smaller PRs and can have more rigorous testing and a focus on individual component development. This PR really focuses on the structure for the "cluster" and the connection from a cluster to a controller. The "controller" right now is just an IndepVarComp because the structure is only set-up to handle one cluster at the moment. The cluster is comprised of 3 main subgroups:

  1. converter: perhaps this should be renamed to "pre_translator". This defines the current operational bounds and also is used to get curve coefficients for the power-to-current conversion.
  2. translator: this is used to take a cluster input power signal and convert it to the cell-level current input
  3. simulation: this takes the cell-level current input and simulates cell degradation, includes dynamic operating constraints, and simulates the cell performance.

Plans for follow-on PRs:

Files to Remove (were helper/drafts):

  • electrolyzer/translators/power_translator_baseclass.py
  • electrolyzer/core/simulate_structure.py
  • electrolyzer/core/pre_processing_structure_v2.py

Related issue, if one exists

Impacted areas of the software

Additional supporting information

n2_diagram

Test results, if applicable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants