Change trough IAM/solar position table widgets

[taylorbrown75]

Description

Modified the physical trough collectors UI page so only the relevant solar position, field incidence, or incidence angle modifier tables are visible, depending on what is selected. This removes the incidence angle modifier coefficient dialog box, and places the table in the UI.

New version:

Previous version:

Corresponding branches and PRs:

All other branches: develop

Unit Test Impact:

Expect no changes to any tests. No change to defaults.

Checklist

• requires help revision and I added that label (I modified the help documentation)
• I've tagged this PR to a milestone

[taylorbrown75]

@cpaulgilman Do you have any thoughts on this change? We are now overlapping two tables and hiding the one that is not active, depending on a user selection.

[Copilot]

Pull request overview

Updates the Physical Trough Collector UI pages to switch between the solar position / incidence angle tables and the IAM coefficients table based on the selected optical model, and aligns the user documentation with the new in-page IAM table (removing references to the prior “Edit data” dialog flow).

Changes:

• Replaces the IAM coefficients widget from a DataArray-style control to an in-page DataArrayTable and toggles visibility via show() callbacks.
• Adjusts layout dimensions/positions to accommodate the new table presentation.
• Updates two help docs to describe editing IAM coefficients directly in the table.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
doc/source/iph-parabolic-trough/iph_trough_collectors.rst	Updates IAM coefficients instructions to reflect in-page table editing.
doc/source/csp-physical-trough-model/troughphysical_collectors_scas.rst	Same documentation update for the physical trough model docs.
deploy/runtime/ui/Physical Trough Collector Type 1.json	Introduces DataArrayTable for IAM coefficients and toggles table visibility based on optical model selection.
deploy/runtime/ui/Physical Trough Collector Type 2.json	Same UI changes for collector Type 2.
deploy/runtime/ui/Physical Trough Collector Type 3.json	Same UI changes for collector Type 3.
deploy/runtime/ui/Physical Trough Collector Type 4.json	Same UI changes for collector Type 4 (plus minor metadata updates).

Comments suppressed due to low confidence (4)

deploy/runtime/ui/Physical Trough Collector Type 1.json:1791

• IAMs_1 is now rendered with a DataArrayTable control in FormObjects, but its VarDatabase entry still declares "UIObject": "DataArray". This mismatch is likely to break widget binding/serialization for the IAM coefficients. Update the IAMs_1 VarDatabase UIObject to DataArrayTable to match the control used on the form.

        "IAMs_1": {
            "Version": 4.0,
            "Type": 2.0,
            "Label": "Incidence angle modifier coefficients",
            "Units": " ",
            "Group": "Physical Trough Collector Type 1",
            "IndexLabels": "",
            "Flags": 3.0,
            "DefaultValue": [
                1.0,
                0.0506,
                -0.1763
            ],
            "UIObject": "DataArray",
            "sscVariableName": "",

deploy/runtime/ui/Physical Trough Collector Type 2.json:1791

• IAMs_2 is displayed using a DataArrayTable in FormObjects, but the VarDatabase entry still uses "UIObject": "DataArray". This inconsistency can prevent the IAM table from binding/editing correctly. Change IAMs_2 VarDatabase UIObject to DataArrayTable.

        "IAMs_2": {
            "Version": 4.0,
            "Type": 2.0,
            "Label": "Incidence angle modifier coefficients",
            "Units": " ",
            "Group": "Physical Trough Collector Type 2",
            "IndexLabels": "",
            "Flags": 3.0,
            "DefaultValue": [
                1.0,
                0.0506,
                -0.1763
            ],
            "UIObject": "DataArray",
            "sscVariableName": "",

deploy/runtime/ui/Physical Trough Collector Type 3.json:1791

• IAMs_3 uses a DataArrayTable control in FormObjects, but its VarDatabase entry still specifies "UIObject": "DataArray". This mismatch is likely to break the IAM coefficients table UI binding. Update the IAMs_3 VarDatabase UIObject to DataArrayTable.

        "IAMs_3": {
            "Version": 4.0,
            "Type": 2.0,
            "Label": "Incidence angle modifier coefficients",
            "Units": " ",
            "Group": "Physical Trough Collector Type 3",
            "IndexLabels": "",
            "Flags": 3.0,
            "DefaultValue": [
                1.0,
                0.0506,
                -0.1763
            ],
            "UIObject": "DataArray",
            "sscVariableName": "",

deploy/runtime/ui/Physical Trough Collector Type 4.json:1791

• IAMs_4 is shown with a DataArrayTable control in FormObjects, but the VarDatabase entry still sets "UIObject": "DataArray". This mismatch can break the IAM coefficients table interaction. Change the IAMs_4 VarDatabase UIObject to DataArrayTable to align with the form control.

        "IAMs_4": {
            "Version": 4.0,
            "Type": 2.0,
            "Label": "Incidence angle modifier coefficients",
            "Units": " ",
            "Group": "Physical Trough Collector Type 3",
            "IndexLabels": "",
            "Flags": 3.0,
            "DefaultValue": [
                1.0,
                0.0506,
                -0.1763
            ],
            "UIObject": "DataArray",
            "sscVariableName": "",

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.