Correct pipe rate units from galUS to galUS/h - #813
Merged
Conversation
johnjasa
approved these changes
Jul 25, 2026
johnjasa
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @jaredthomas68!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct pipe rate units from galUS to galUS/h
The pipe transporter specified units of galUS for the rate units of water, which was then propagated into the iron work. This PR corrects rate units from galUS to galUS/h where appropriate.
Section 1: Type of Contribution
Section 2: Draft PR Checklist
TODO:
Type of Reviewer Feedback Requested (on Draft PR)
Structural feedback:
Implementation feedback:
Other feedback:
Section 3: General PR Checklist
docs/files are up-to-date, or added when necessaryCHANGELOG.md"A complete thought. [PR XYZ]((https://github.com/NatLabRockies/H2Integrate/pull/XYZ)", where
XYZshould be replaced with the actual number.Section 4: Related Issues
Somewhat related to #223
Section 5: Impacted Areas of the Software
Section 5.1: New Files
Section 5.2: Modified Files
examples/21_iron_examples/iron_dri/tech_config.yaml
commodity_rate_units (technologies entries): Updated water commodity rate units from galUS to galUS/h to represent a flow rate consistently with hourly usage assumptions.
examples/21_iron_examples/iron_mapping/tech_config.yaml
commodity_rate_units (technologies entry): Updated water commodity rate units from galUS to galUS/h for consistency with rate-based feedstock accounting.
h2integrate/converters/iron/iron_dri_plant.py
HydrogenIronReductionPlantPerformanceComponent (line 69): Changed water units mapping to galUS/h so internal unit metadata matches hourly commodity rates.
NaturalGasIronReductionPlantPerformanceComponent (line 96): Changed water units mapping to galUS/h for parity with the hydrogen pathway and downstream unit checks.
h2integrate/converters/iron/test/test_rosner_dri.py
ng_feedstock_availability_costs (line 50): Updated expected water units from galUS to galUS/h to match converter unit definitions.
h2_feedstock_availability_costs (line 83): Updated expected water units from galUS to galUS/h to keep hydrogen-case assertions aligned.
h2integrate/converters/steel/steel_eaf_plant.py
HydrogenEAFPlantPerformanceComponent (line 66): Changed water units mapping to galUS/h to use hourly flow units.
NaturalGasEAFPlantPerformanceComponent (line 93): Changed water units mapping to galUS/h for consistent EAF feedstock-rate treatment.
h2integrate/converters/steel/test/test_rosner_eaf.py
ng_feedstock_availability_costs (line 65): Updated expected water units to galUS/h so test expectations match EAF model output metadata.
h2_feedstock_availability_costs (line 103): Updated expected water units to galUS/h for hydrogen EAF case consistency.
h2integrate/feedstocks/test/test_feedstocks.py
test_multiple_different_type_feedstocks (line 328): Corrected electricity units expectation from MW*h to MW to align with rate-based input conventions.
test_multiple_different_type_feedstocks (line 334): Updated water units expectation from galUS to galUS/h to align with hourly water consumption rates.
h2integrate/transporters/pipe.py
PipePerformanceModel unit selection (line 41): Changed water commodity units from galUS to galUS/h.
Section 6: Additional Supporting Information
Section 7: Test Results, if applicable
Section 8 (Optional): New Model Checklist
docs/developer_guide/coding_guidelines.mdattrsclass to define theConfigto load in attributes for the modelBaseConfigorCostModelBaseConfiginitialize()method,setup()method,compute()methodCostModelBaseClasssupported_models.pycreate_financial_modelinh2integrate_model.pytest_all_examples.pydocs/user_guide/model_overview.mddocs/section<model_name>.mdis added to the_toc.ymlgenerate_class_hierarchy.pyto update the class hierarchy diagram indocs/developer_guide/class_structure.md