Add stop_when_flux_decayed termination criteria#3221
Open
oskooi wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new
stop_when_flux_decayedtermination criteria which is similar to the existingstop_when_dft_decayed. Also includes a unit test.The new termination criteria is particularly useful in cases involving glancing-angle waves which are poorly absorbed by PML (and for which the existing termination criteria
stop_when_fields_decayedandstop_when_dft_decayedtend to require long run times which can cause field instabilities).As an example, a planewave incident at oblique angles on a binary grating produces high-angle diffraction orders which tend to be slowly decaying within the periodic unit cell. Tracking the convergence of the Poynting flux in the direction of the PML absorption (i.e.,$z$ direction for a 3D unit cell periodic in $x$ and $y$ ) enables terminating the simulation within a reasonable time (although choosing the
tolparameter based on empirical testing requires some care).