Skip to content

tests added #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NamigGadir merged 1 commit into from
Jul 29, 2025
Merged

tests added #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions app/src/test/java/com/coderabbit/app/ExampleUnitTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,9 @@ public class ExampleUnitTest {
public void addition_isCorrect() {
assertEquals(4, 2 + 2);
}

@Test
public void addition_isFalse() {
assertTrue(true);
}
Comment on lines +18 to +21

@coderabbitai coderabbitai Bot Jul 29, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Remove or fix this meaningless test.

This test method has several issues:

  • The method name addition_isFalse is misleading and doesn't match what's being tested
  • assertTrue(true) is a trivial assertion that always passes and provides no testing value
  • The test doesn't verify any actual functionality

Either remove this test or replace it with a meaningful test:

-    @Test
-    public void addition_isFalse() {
-        assertTrue(true);
-    }
+    @Test
+    public void addition_isIncorrect() {
+        assertNotEquals(5, 2 + 2);
+    }
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
@Test
public void addition_isFalse() {
assertTrue(true);
}
@Test
public void addition_isIncorrect() {
assertNotEquals(5, 2 + 2);
}
🤖 Prompt for AI Agents 
In app/src/test/java/com/coderabbit/app/ExampleUnitTest.java around lines 18 to
21, the test method addition_isFalse is misleading and trivial because it
asserts true unconditionally. Replace this test with a meaningful one that
verifies actual functionality or remove it entirely if it serves no purpose.

}
8 changes: 8 additions & 0 deletions app/src/test/java/com/coderabbit/app/calculator/CalculatorTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,4 +48,12 @@ class CalculatorTest {
calculator.divide(17,0)
}
}

@Test
fun `test divide function che divide zero by twenty`() {
val calculator = Calculator()
assertThrows(ArithmeticException::class.java){
calculator.divide(20,0)
}
}
Comment on lines +52 to +58

@coderabbitai coderabbitai Bot Jul 29, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Remove duplicate division-by-zero test.

This test is functionally identical to the existing division-by-zero tests (lines 29-34, 37-42, 45-50). Testing division by zero with different dividends doesn't provide additional value since the behavior should be consistent regardless of the dividend.

Consider removing this duplicate test:

-    @Test
-    fun `test divide function che divide zero by twenty`() {
-        val calculator = Calculator()
-        assertThrows(ArithmeticException::class.java){
-            calculator.divide(20,0)
-        }
-    }

The existing division-by-zero tests already provide adequate coverage for this edge case.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
@Test
fun `test divide function che divide zero by twenty`() {
val calculator = Calculator()
assertThrows(ArithmeticException::class.java){
calculator.divide(20,0)
}
}
🤖 Prompt for AI Agents 
In app/src/test/java/com/coderabbit/app/calculator/CalculatorTest.kt around
lines 52 to 58, remove the duplicate test function that checks division by zero
with dividend 20, as this case is already covered by existing tests on lines
29-50. Deleting this redundant test will keep the test suite concise without
losing coverage.

}