Skip to content

Car class added and Tests also added #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NamigGadir wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Car class added and Tests also added #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions app/src/main/java/com/coderabbit/app/calculator/Car.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
package com.coderabbit.app.calculator

class Car {

fun startEngine(): Boolean {
println("Engine is starting...")
return true
}

fun isEngineStarted(): Boolean {
// Simulate engine status
return true
}
}
Comment on lines +3 to +14

@coderabbitai coderabbitai Bot Aug 8, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Make Car stateful and eliminate println side-effects

Both methods currently hardcode success and provide no observable state, which limits usefulness and testability. Model engine state and remove println side-effects.

Apply:

-class Car {
-
-    fun startEngine(): Boolean {
-        println("Engine is starting...")
-        return true
-    }
-
-    fun isEngineStarted(): Boolean {
-        // Simulate engine status
-        return true
-    }
-}
+class Car {
+    private var engineStarted: Boolean = false
+
+    fun startEngine(): Boolean {
+        if (engineStarted) return true // idempotent
+        // TODO: plug real start logic here
+        engineStarted = true
+        return true
+    }
+
+    fun isEngineStarted(): Boolean = engineStarted
+}
🤖 Prompt for AI Agents 
In app/src/main/java/com/coderabbit/app/calculator/Car.kt from lines 3 to 14,
the Car class methods startEngine and isEngineStarted always return true and do
not maintain any engine state, plus startEngine uses println causing side
effects. Refactor the class to include a private Boolean property to track the
engine state, update this state in startEngine without printing anything, and
have isEngineStarted return the current state instead of a hardcoded value.

16 changes: 16 additions & 0 deletions app/src/test/java/com/coderabbit/app/calculator/CarTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
package com.coderabbit.app.calculator

import org.junit.Assert.assertTrue


class CarTest {

fun startEngine() {
// Arrange
val car = Car()
// Act
val result = car.startEngine()
// Assert
assertTrue(result)
}
}