Skip to content

4.0.0 beta03 fixes #933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Nain57 wants to merge 8 commits into
base: master
Choose a base branch
from
Open

4.0.0 beta03 fixes #933

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e0eb8f1
Fix rotation in menu overlay ordering
Nain57 Jun 24, 2026
1f607f6
[#926] Fix counter starting value input field
Nain57 Jun 25, 2026
7d6b640
[#926] Fix empty counter appearing after migrations
Nain57 Jun 25, 2026
a3b7548
[#930] Fix input field invalid init values
Nain57 Jun 25, 2026
ae201a3
[#926] Use back arrow for counter menu dismiss button
Nain57 Jun 25, 2026
512bffa
[#928] Handle never used case for scenario time since
Nain57 Jun 26, 2026
46369b7
[#929] Cleanup Detection engine destroyed state
Nain57 Jun 26, 2026
f5e34dc
[#931] Fix crash on malformed scenario loading
Nain57 Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .../src/main/java/com/buzbuz/smartautoclicker/core/common/overlays/manager/OverlayManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,7 @@ class OverlayManager @Inject internal constructor(
}

private fun onOrientationChanged() {
overlayBackStack.forEachReversed { it.changeOrientation() }
overlayBackStack.forEach { it.changeOrientation() }
}

override fun dump(writer: PrintWriter, prefix: CharSequence) {
Expand Down
9 changes: 6 additions & 3 deletions ...on/ui/src/main/java/com/buzbuz/smartautoclicker/core/ui/bindings/fields/FieldTextInput.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ import android.text.InputType
import android.view.inputmethod.EditorInfo

import androidx.annotation.StringRes
import androidx.core.widget.doAfterTextChanged

import com.buzbuz.smartautoclicker.core.ui.R
import com.buzbuz.smartautoclicker.core.ui.databinding.IncludeFieldTextInputBinding
Expand All @@ -34,11 +33,13 @@ fun IncludeFieldTextInputBinding.setLabel(@StringRes labelResId: Int) {

fun IncludeFieldTextInputBinding.setText(text: String?, type: Int = InputType.TYPE_CLASS_TEXT) {
textField.apply {
if (hasFocus()) return
val initialized = tag as? Boolean ?: false
if (initialized && hasFocus()) return

inputType = type
imeOptions = EditorInfo.IME_ACTION_DONE
setText(text)
tag = true
}
}

Expand All @@ -51,5 +52,7 @@ fun IncludeFieldTextInputBinding.setError(@StringRes messageId: Int, isError: Bo
}

fun IncludeFieldTextInputBinding.setOnTextChangedListener(listener: (Editable) -> Unit) {
textField.addTextChangedListener(OnAfterTextChangedListener(listener))
textField.addTextChangedListener(OnAfterTextChangedListener { editable ->
if (textField.hasFocus()) listener(editable)
})
}
12 changes: 9 additions & 3 deletions ...in/java/com/buzbuz/smartautoclicker/core/ui/bindings/fields/FieldTextInputWithCheckbox.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,21 +42,25 @@ fun IncludeFieldTextInputWithCheckboxBinding.setup(

fun IncludeFieldTextInputWithCheckboxBinding.setNumericValue(value: String, force: Boolean = false) {
textField.apply {
if (hasFocus() && !force) return
val initialized = tag as? Boolean ?: false
if (initialized && hasFocus() && !force) return

inputType = InputType.TYPE_CLASS_NUMBER
imeOptions = EditorInfo.IME_ACTION_DONE
textField.setText(value)
tag = true
}
}

fun IncludeFieldTextInputWithCheckboxBinding.setTextValue(value: String?, force: Boolean = false) {
textField.apply {
if (hasFocus() && !force) return
val initialized = tag as? Boolean ?: false
if (initialized && hasFocus() && !force) return

inputType = InputType.TYPE_CLASS_TEXT
imeOptions = EditorInfo.IME_ACTION_DONE
textField.setText(value)
tag = true
}
}

Expand All @@ -83,7 +87,9 @@ fun IncludeFieldTextInputWithCheckboxBinding.setError(@StringRes messageId: Int,
}

fun IncludeFieldTextInputWithCheckboxBinding.setOnTextChangedListener(listener: (Editable) -> Unit) {
textField.addTextChangedListener(OnAfterTextChangedListener(listener))
textField.addTextChangedListener(OnAfterTextChangedListener { editable ->
if (textField.hasFocus()) listener(editable)
})
}

fun IncludeFieldTextInputWithCheckboxBinding.setOnCheckboxClickedListener(listener: () -> Unit) {
Expand Down
Loading
Loading