Skip to content

test: cover critical regression paths - #1045

Open
vibhor1102 wants to merge 1 commit into
Nain57:masterfrom
vibhor1102:feature/regression-test-coverage
Open

test: cover critical regression paths#1045
vibhor1102 wants to merge 1 commit into
Nain57:masterfrom
vibhor1102:feature/regression-test-coverage

Conversation

@vibhor1102

@vibhor1102 vibhor1102 commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds regression coverage for critical paths across gesture execution, database migrations, scenario backup import, counters, actions, conditions, events, and scenario editing.

The branch targets dev-4.0.0-beta08-fixes and contains the test commit only. The temporary hosted verification workflow used during validation was removed before opening this PR.

Findings from verification

The hosted verification run executed the independent test tasks and exposed four failures. The tests appear valid and are intentionally left unfixed for maintainer review:

  • A late gesture callback can complete the next gesture after a timeout.
  • Migration 19 to 20 does not actually process lowercase persisted enum values despite normalizing them in Kotlin.
  • Current-version smart backup imports reject unknown nested fields despite the forward-compatibility intent.
  • The counter creation command can add a whitespace-only counter when called directly, although the normal UI disables Save.

These findings are tracked in #1046. This PR adds the regression tests only; production fixes are intentionally left for separate maintainer follow-up.

Validation

Hosted verify run: https://github.com/vibhor1102/Smart-AutoClicker/actions/runs/31606697584

The run used the temporary verify-only workflow and reported the four test failures above. No local Gradle tests were run because repository guidance prohibits local compilation/testing on this machine.

@vibhor1102
vibhor1102 marked this pull request as ready for review August 12, 2026 14:54
Nain57 added a commit that referenced this pull request Aug 17, 2026

@Nain57 Nain57 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other comments can be found here #1046

Part of this commit have been integrated with their fixes: #1043

@Nain57 Nain57 mentioned this pull request Aug 17, 2026
Nain57 added a commit that referenced this pull request Aug 17, 2026
@vibhor1102
vibhor1102 force-pushed the feature/regression-test-coverage branch from e2bb70f to 7449a1d Compare August 18, 2026 14:21
@vibhor1102
vibhor1102 changed the base branch from dev-4.0.0-beta08-fixes to master August 18, 2026 14:21
@vibhor1102
vibhor1102 force-pushed the feature/regression-test-coverage branch from c11f6cb to 7449a1d Compare August 18, 2026 14:29
@vibhor1102

Copy link
Copy Markdown
Contributor Author

Thanks for the review. I have updated the PR accordingly:

  • rebased and retargeted it onto master;
  • removed the GestureExecutor and counter-creation tests now covered by Bugfixes 4.0.0-beta08 #1043;
  • removed the lowercase migration, unknown backup field, and Room auto-migration tests;
  • restored the complete legal headers in the affected files.

The remaining eight test files passed the hosted unit-test workflow: https://github.com/vibhor1102/Smart-AutoClicker/actions/runs/32147825321

@vibhor1102
vibhor1102 requested a review from Nain57 August 18, 2026 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants