Enable R8 minification for release builds - #70
Merged
Conversation
Dependencies (Room, kotlinx-serialization, coil) ship their own consumer rules and Koin resolves by direct class reference, so no blanket rules are needed.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enable R8 code shrinking and resource shrinking for the release build type, backed by a new
proguard-rules.pro. Also removes an unused Coil dependency and adds a new tip card promoting the pick history feature.Changes
isMinifyEnabled+isShrinkResourcesfor release, withproguard-android-optimize.txtandproguard-rules.proproguard-rules.prowith rationale commentscoil-network-ktor2from the version catalog (only ktor3 is used)TipCardand add a "history"NewFeatureTipCard, including thetip_historystring in all 14 localesWhy no R8 keep rules
Room, kotlinx-serialization and Coil ship their own consumer rules, and Koin 4.x resolves definitions by direct class reference, so R8 retains what's needed without blanket keep rules.