Repository navigation
ci: run the shared publish gates before the PyPI upload - #14
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
publish.yml now calls the shared
publish-gates.ymlfrom NaNIsaac/.github, pinned to commit 284b0786020434df16b096a3e11c56c6331dd81f, before the upload. The upload stays in this file with thereleaseenvironment, so the PyPI Trusted Publisher registration is unchanged.gatesjob: build the sdist and wheel once, runuv run pytest -q, scan the built files for credential file names, files over 5 MB, home-folder paths and secrets, and install the wheel alone in a clean venv, importroi_rectangleand compare the installed version with the expected one.publishjob: needsgates, runs only on av*tag, keeps the tag-matches-pyproject check, and uploads the files the gates checked (artifactpublish-gates-dist) instead of building again.workflow_dispatchruns the gates alone, with no upload. Off a tag the install check compares with the pyproject version instead of the tag.GitHub only offers
workflow_dispatchfor a workflow file on the default branch, so the gates-only run can be started once this is on main:gh workflow run publish.yml -R NaNIsaac/roi_rectangle.local-ci: 8c964b6 |
uv sync --locked,uv run pytest -q: 34 passed; the pinned gates' leak checks on a local 1.1.0 build: no findings | the workflow itself not run (dispatch needs the file on main)Part of: PUBLISH-GATES-ROLLOUT