Repository navigation
fix: drop undeclared click import and release 0.14.1 - #69
Merged
Merged
Conversation
NaNIsaac
force-pushed
the
fix/click-import-0.14.1
branch
from
November 16, 2026 08:37
90547dc to
9c2764b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
from click.core import ParameterSourceimport insrc/codigest/commands/term.pyand comparegetattr(ctx.get_parameter_source("count"), "name", None) == "DEFAULT", which works with bothtyper0.20 (clickenum) andtyper0.29+ (typer._clickvendored enum) without declaringclick.import clickusages insite/scripts/check_reference.pyanddocs/cli_matrix.pyby inspectingcommandsandparam_type_nameattributes directly.tests/test_term_list.pyverifyingcdg term --listwithout-nlists all entries.uv run --python 3.15 --no-project --with .) in.github/workflows/ci.ymlrunningcdg --versionandcdg term --listso missing undeclared dependencies fail CI.typerinuv.lockfrom0.20.0to0.29.1(full suite and reference check pass undertyper0.29.1).0.14.1.Verification
uvx ruff@0.17.1 checkanduvx ruff@0.17.1 format --checkuv run python site/scripts/check_reference.py(reference matches the CLI: 21 commands, 116 options)uv run --python 3.15 --no-project --with . cdg --version(codigest 0.14.1) andcdg term --listpytest -qundertyper 0.29.1: 318 passed, 21 skippedpytest --with pywinpty tests/test_term_list.py tests/test_hook_terminal.py -q: 17 passed, 9 skippedcargo fmt --check,cargo clippy --all-targets -- -D warnings, andCODIGEST_PARITY=1 cargo test --no-fail-fast -- --include-ignored: 239 passed, 0 failedPart of: CDG-RELEASE