Expo 56 Follow Up#1193
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This address comments from the initial Expo 56 PR: #1189
Introducing
useAnalyticsPostHog introduced return
Promisesfor a few of their API calls in v4. As per the comment on the last PR, I was going to create afireAndForgethelper function so that the calls to PostHog that are now usingvoidwill log errors that come from PostHog. However, that means that anytime we add ascreencall, we need to remember to wrap it infireAndForget. To make it easier/less error prone, I introduced auseAnalyticshook that wraps PostHog so that we can call the functions correctly without having to wrap them infireAndForget. There still is a newfireAnForgetutility function that we can use for other things.@types/jest
Removed the reference to jest from
declarations.d.tsinto thetypesproperty intsconfig.jsreanimatedmocksThe mocking for
react-native-reanimatednow uses their approvedsetupTests()Small tweak
Added the
paddingBottom={safeAreaInsets.bottom}back to the selection modal, but on the button instead of the scroll view content