Skip to content

Expo 56 Follow Up#1193

Merged
kevinherdez merged 2 commits into
NWACus:mainfrom
kevinherdez:kevinherdez/expo56FollowUp
Jun 5, 2026
Merged

Expo 56 Follow Up#1193
kevinherdez merged 2 commits into
NWACus:mainfrom
kevinherdez:kevinherdez/expo56FollowUp

Conversation

@kevinherdez
Copy link
Copy Markdown
Collaborator

This address comments from the initial Expo 56 PR: #1189

Introducing useAnalytics

PostHog introduced return Promises for a few of their API calls in v4. As per the comment on the last PR, I was going to create a fireAndForget helper function so that the calls to PostHog that are now using void will log errors that come from PostHog. However, that means that anytime we add a screen call, we need to remember to wrap it in fireAndForget. To make it easier/less error prone, I introduced a useAnalytics hook that wraps PostHog so that we can call the functions correctly without having to wrap them in fireAndForget. There still is a new fireAnForget utility function that we can use for other things.

@types/jest

Removed the reference to jest from declarations.d.ts into the types property in tsconfig.js

reanimated mocks

The mocking for react-native-reanimated now uses their approved setupTests()

Small tweak

Added the paddingBottom={safeAreaInsets.bottom} back to the selection modal, but on the button instead of the scroll view content

@kevinherdez kevinherdez added this pull request to the merge queue Jun 5, 2026
Merged via the queue into NWACus:main with commit 210b9c1 Jun 5, 2026
5 checks passed
@kevinherdez kevinherdez deleted the kevinherdez/expo56FollowUp branch June 5, 2026 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant