Media Viewer Updates#1179
Open
kevinherdez wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first commit is the fix for the MediaPreview error state. It just needed to be wrapped in a view that was the same height and width of the thumbnail to render correctly
PDF Viewing
The second commit introduces viewing PDFs in the app. This experience works in the same way that the
WebVideoViewdoes which is presenting the PDF inside of aWebViewsince bothWebViewson iOS and Android support PDF viewing.Important Changes
A lot of the code for
WebVideoViewwas broken out intoWebMediaViewthat now bothWebVideoViewand the newPDFViewutilize. TheWebViewcode was also cleaned up to better handle centering the viewA new
PDFThumbnailview was added. This mimics the web experience in that we don't show the preview of the PDF itself. Instead we just show that we have a document in the list and show an icon.