Fix: VeraRubin host BMC displays boot order in a different format#168
Open
hakhondzadeh wants to merge 3 commits into
Open
Fix: VeraRubin host BMC displays boot order in a different format#168hakhondzadeh wants to merge 3 commits into
hakhondzadeh wants to merge 3 commits into
Conversation
poroh
reviewed
Jul 25, 2026
| /// is classified as Vera Rubin (`Vendor=NVIDIA`, `Product=VR NVL72`). | ||
| #[cfg(feature = "boot-options")] | ||
| #[must_use] | ||
| pub fn boot_option_matches_boot_order_entry( |
Contributor
There was a problem hiding this comment.
This solution is not ideal because it requires user to know that this is the only way to match boot option to boot order entry. I would suggest to add patch support for ComputerSystem item and remove ": " before deserialization to ComputerSystemSchema.
All user logic will remain the same as today.
To do this you need to introduce additional patch function similar to:
nv-redfish/redfish/src/computer_system/mod.rs
Line 114 in c62a65a
You can find couple similar functions nearby.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redfish path redfish/v1/Systems/System_0 for a Vera Rubin host bmc, show boot orders in this format:
"BootOrder": [ "Boot0019: Ubuntu", "Boot0008: UEFI HTTPv4 (MAC:AC3AE2634C82)",
While previously, we saw them in this format:
"BootOrder": [
"Boot0002",
"Boot0001",
"Boot0000"
],
This PR fixes this issue so that boot order is properly added to exploration report.