Skip to content

patch(2.0): Nil check DPU extension timestamp error logging (#3744)#4119

Open
hwadekar-nv wants to merge 2 commits into
NVIDIA:release/v2.0from
hwadekar-nv:3744-release-v2.0
Open

patch(2.0): Nil check DPU extension timestamp error logging (#3744)#4119
hwadekar-nv wants to merge 2 commits into
NVIDIA:release/v2.0from
hwadekar-nv:3744-release-v2.0

Conversation

@hwadekar-nv

Copy link
Copy Markdown
Contributor

Backports #3744 to release/v2.0.

Description:

  • The timestamp parse branch was inverted, causing successful parses to log errors while failures were silent.
  • The fix logs non-empty parse failures and preserves the existing fallback timestamp.
  • Added coverage for valid and invalid timestamps, then ran the full dpuextensionservice package tests successfully.

Type of Change

  • Fix - Bug fixes

Testing

  • Unit tests added/updated

…A#3744)

Description: 
- The timestamp parse branch was inverted, causing successful parses to
log errors while failures were silent.
- The fix logs non-empty parse failures and preserves the existing
fallback timestamp.
- Added coverage for valid and invalid timestamps, then ran the full
dpuextensionservice package tests successfully.

Type of Change
- [x] **Fix** - Bug fixes

Testing
- [x] Unit tests added/updated
@hwadekar-nv
hwadekar-nv requested a review from a team July 24, 2026 17:42
@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 92a462e5-3c7b-4310-a0ef-9899c8b116b7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@hwadekar-nv hwadekar-nv self-assigned this Jul 24, 2026
@hwadekar-nv
hwadekar-nv requested a review from nv-dmendoza July 24, 2026 17:42
@github-actions

Copy link
Copy Markdown

🔐 TruffleHog Secret Scan

No secrets or credentials found!

Your code has been scanned for 700+ types of secrets and credentials. All clear! 🎉

🔗 View scan details

🕐 Last updated: 2026-07-24 17:46:23 UTC | Commit: dfedd6e

@github-actions

github-actions Bot commented Jul 24, 2026

Copy link
Copy Markdown

🔍 Container Scan Summary

Service Total Critical High Medium Low Other
boot-artifacts-aarch64 3 0 0 3 0 0
boot-artifacts-x86_64 3 0 0 3 0 0
forge-admin-cli-x86_64 260 16 29 79 8 128
machine-validation-runner 548 41 117 191 18 181
machine_validation 548 41 117 191 18 181
machine_validation-aarch64 548 41 117 191 18 181
nvmetal-carbide 548 41 117 191 18 181
TOTAL 2458 180 497 849 80 852

Per-CVE detail lives in the per-service grype-* artifacts (JSON + SARIF). Severity counts only — no CVE IDs published here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant