Skip to content

docs: add GPU support to HCL#4112

Open
jpc204 wants to merge 3 commits into
NVIDIA:mainfrom
jpc204:agent/add-gpu-support-to-hcl
Open

docs: add GPU support to HCL#4112
jpc204 wants to merge 3 commits into
NVIDIA:mainfrom
jpc204:agent/add-gpu-support-to-hcl

Conversation

@jpc204

@jpc204 jpc204 commented Jul 24, 2026

Copy link
Copy Markdown

Summary

  • add a GPUs section immediately after the existing DPUs section
  • document support for all current NVIDIA data center GPUs
  • clarify that platform-specific GPU qualification, certification, thermal, power, and configuration guidance remains with the server manufacturer
  • keep the existing host/platform compatibility information at the top of the HCL

Impact

Readers can now confirm NICo's general GPU support policy directly in the Hardware Compatibility List while retaining the existing platform-first organization.

Validation

  • git diff --check
  • reviewed the rendered Markdown structure and exact approved copy

@copy-pr-bot

copy-pr-bot Bot commented Jul 24, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 2b55dbaf-c7fc-474a-a5b1-2306871878c0

📥 Commits

Reviewing files that changed from the base of the PR and between 1245894 and 7bdd0c7.

📒 Files selected for processing (1)
  • docs/hcl.md
🚧 Files skipped from review as they are similar to previous changes (1)
  • docs/hcl.md

Summary by CodeRabbit

  • Documentation
    • Added a GPUs section to the HCL documentation.
    • Clarified that NICo supports all current NVIDIA data center GPUs.
    • Stated that GPU compatibility isn’t validated per platform and should be confirmed with the server manufacturer’s guidance.

Walkthrough

The HCL documentation now describes support for current NVIDIA data center GPUs, clarifies that platform-specific compatibility is not validated in the HCL, and directs readers to server manufacturers for qualification details.

Changes

GPU documentation

Layer / File(s) Summary
GPU support guidance
docs/hcl.md
Adds a GPUs section with NVIDIA data center GPU support guidance, platform validation clarification, manufacturer qualification direction, and an initial GPU support table entry.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: adding GPU support documentation to the HCL.
Description check ✅ Passed The description is clearly aligned with the documented HCL GPU section changes and validation steps.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@jpc204
jpc204 marked this pull request as ready for review July 24, 2026 16:41
@jpc204
jpc204 requested a review from polarweasel as a code owner July 24, 2026 16:41

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/hcl.md`:
- Around line 65-67: Update the “Last Updated” metadata in the HCL documentation
to reflect the addition of the GPUs section, using the current date of the
change. Leave the GPU support content unchanged.
- Around line 67-73: Clarify the GPU table’s “Supported” scope by renaming the
support column or qualifying the row to explicitly describe NICo/NVIDIA
software-stack support, consistent with the page disclaimer. Replace the
unbounded “Current NVIDIA Data Center GPUs” wording with a release/date anchor
or an explicit supported GPU-family list, while preserving operator-facing
guidance.
- Around line 71-73: Update the GPU support table in the HCL documentation so
the header, separator, and data rows all have leading and trailing pipes,
following the repository’s required MD055 table style.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 323a0571-1cf5-4541-968e-1ad959b705d9

📥 Commits

Reviewing files that changed from the base of the PR and between 1bac3d0 and 8139bc8.

📒 Files selected for processing (1)
  • docs/hcl.md

Comment thread docs/hcl.md Outdated
Comment thread docs/hcl.md Outdated
Comment thread docs/hcl.md Outdated
Comment thread docs/hcl.md Outdated
Comment thread docs/hcl.md Outdated

@polarweasel polarweasel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the table for ya

Comment thread docs/hcl.md Outdated
jpc204 and others added 3 commits July 25, 2026 08:15
Signed-off-by: Jared Conway <jaredc@nvidia.com>
Co-authored-by: Alex Ball <awball@polarweasel.org>
Signed-off-by: jpc204 <50123158+jpc204@users.noreply.github.com>
Co-authored-by: Alex Ball <awball@polarweasel.org>
Signed-off-by: jpc204 <50123158+jpc204@users.noreply.github.com>
@jpc204
jpc204 force-pushed the agent/add-gpu-support-to-hcl branch from 1245894 to 7bdd0c7 Compare July 25, 2026 12:17
@github-actions

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants