perf(build): reduce debug info for CI tests#4111
Conversation
|
/ok to test c33aeac |
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
WalkthroughThe release-container service test path now uses a dedicated ChangesCI test profile execution
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
c33aeac to
b70c120
Compare
|
/ok to test b70c120 |
Signed-off-by: Dmitry Porokh <dporokh@nvidia.com>
b70c120 to
e8268f2
Compare
There was a problem hiding this comment.
🧹 Nitpick comments (1)
Makefile.toml (1)
714-717: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winLock dependency resolution in CI.
Add
--lockedso this test task fails on a stale lockfile instead of silently resolving a different dependency graph.Suggested change
args = [ "test", "--profile=ci-tests", + "--locked", ]🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@Makefile.toml` around lines 714 - 717, Update the cargo test task in the Makefile configuration to include the --locked argument alongside --profile=ci-tests, ensuring CI uses the committed lockfile without resolving dependency changes.Source: Path instructions
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@Makefile.toml`:
- Around line 714-717: Update the cargo test task in the Makefile configuration
to include the --locked argument alongside --profile=ci-tests, ensuring CI uses
the committed lockfile without resolving dependency changes.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 2ca4e084-496f-4125-b346-44400aa7450e
📒 Files selected for processing (3)
.github/workflows/ci.yamlCargo.tomlMakefile.toml
💤 Files with no reviewable changes (1)
- .github/workflows/ci.yaml
The
test-release-container-servicesjob builds the workspace test targets using Cargo’s development profile. Development builds generate full debug information by default, adding unnecessary work to the job’s lengthy compilation phase.Add a dedicated
ci-testsprofile that inherits development behavior but generates line tables instead of complete debug metadata. The workflow passes this profile through cargo-make when compiling and running the tests.Line tables preserve function names and source locations in panic backtraces, while avoiding the cost of generating debug information intended for interactive debugging. Local development and release profiles remain unchanged.
Related issues
N/A
Type of Change
Breaking Changes
Testing
Additional Notes
It reduces tests compilation time from ~8m to ~5m 30s.