Skip to content

patch(2.0): Make ovs port moves tolerant to OVS failures (#4029)#4098

Merged
nv-dmendoza merged 1 commit into
NVIDIA:release/v2.0from
bcavnvidia:backport/4029-release-v2.0
Jul 24, 2026
Merged

patch(2.0): Make ovs port moves tolerant to OVS failures (#4029)#4098
nv-dmendoza merged 1 commit into
NVIDIA:release/v2.0from
bcavnvidia:backport/4029-release-v2.0

Conversation

@bcavnvidia

Copy link
Copy Markdown
Contributor

Backports #4029 to release/v2.0.

DPU provisioning can encounter a transient OVS failure when a host PF/VF representor has not materialized yet. That failure currently terminates cloud-init before service restart and Scout execution.

This change keeps the existing OVS configuration and ofport_request synchronization attempts, but makes those operations tolerant of the expected transient failure. The working PF path remains unchanged.

Related issues

Type of Change

  • Add - New feature or capability
  • Change - Changes in existing functionality
  • Fix - Bug fixes
  • Remove - Removed features or deprecated functionality
  • Internal - Internal changes (refactoring, tests, docs, etc.)

Breaking Changes

  • This PR contains breaking changes

No breaking changes are expected.

Testing

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed
  • No testing required (docs, internal refactor, etc.)

Additional Notes

Cherry-picked from 58959fc.

The production template change is unchanged from the original fix. The associated test was adapted to preserve the existing release/v2.0 assertions.

Allow DPU provisioning to continue when a host VF representor has not
materialized yet.

OVS configuration and ofport_request synchronization are still attempted
normally, preserving the working PF path, while expected transient
failures no longer terminate cloud-init before service restart and Scout
execution

NVIDIA#4028

<!-- Check one that best describes this PR -->
- [ ] **Add** - New feature or capability
- [ ] **Change** - Changes in existing functionality
- [ ] **Fix** - Bug fixes
- [ ] **Remove** - Removed features or deprecated functionality
- [ ] **Internal** - Internal changes (refactoring, tests, docs, etc.)

- [ ] **This PR contains breaking changes**

- [x] Unit tests added/updated
- [ ] Integration tests added/updated
- [ ] Manual testing performed
- [ ] No testing required (docs, internal refactor, etc.)

Closes NVIDIA#4028

(cherry picked from commit 58959fc)
Signed-off-by: brian <bcavanagh@nvidia.com>
@bcavnvidia
bcavnvidia requested a review from a team July 24, 2026 14:03
@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 66a059fe-0eef-48fa-bb46-108a20ebf1c6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

🔐 TruffleHog Secret Scan

No secrets or credentials found!

Your code has been scanned for 700+ types of secrets and credentials. All clear! 🎉

🔗 View scan details

🕐 Last updated: 2026-07-24 14:06:05 UTC | Commit: c26453e

@github-actions

github-actions Bot commented Jul 24, 2026

Copy link
Copy Markdown

🔍 Container Scan Summary

Service Total Critical High Medium Low Other
boot-artifacts-aarch64 3 0 0 3 0 0
boot-artifacts-x86_64 3 0 0 3 0 0
forge-admin-cli-x86_64 260 16 29 79 8 128
machine-validation-runner 548 41 117 191 18 181
machine_validation 548 41 117 191 18 181
machine_validation-aarch64 548 41 117 191 18 181
nvmetal-carbide 548 41 117 191 18 181
TOTAL 2458 180 497 849 80 852

Per-CVE detail lives in the per-service grype-* artifacts (JSON + SARIF). Severity counts only — no CVE IDs published here.

@nv-dmendoza nv-dmendoza left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, backports a needed fix

@nv-dmendoza
nv-dmendoza merged commit ced7bbe into NVIDIA:release/v2.0 Jul 24, 2026
120 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants