patch(2.0): Make ovs port moves tolerant to OVS failures (#4029)#4098
Conversation
Allow DPU provisioning to continue when a host VF representor has not materialized yet. OVS configuration and ofport_request synchronization are still attempted normally, preserving the working PF path, while expected transient failures no longer terminate cloud-init before service restart and Scout execution NVIDIA#4028 <!-- Check one that best describes this PR --> - [ ] **Add** - New feature or capability - [ ] **Change** - Changes in existing functionality - [ ] **Fix** - Bug fixes - [ ] **Remove** - Removed features or deprecated functionality - [ ] **Internal** - Internal changes (refactoring, tests, docs, etc.) - [ ] **This PR contains breaking changes** - [x] Unit tests added/updated - [ ] Integration tests added/updated - [ ] Manual testing performed - [ ] No testing required (docs, internal refactor, etc.) Closes NVIDIA#4028 (cherry picked from commit 58959fc) Signed-off-by: brian <bcavanagh@nvidia.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
🔐 TruffleHog Secret Scan✅ No secrets or credentials found! Your code has been scanned for 700+ types of secrets and credentials. All clear! 🎉 🕐 Last updated: 2026-07-24 14:06:05 UTC | Commit: c26453e |
🔍 Container Scan Summary
Per-CVE detail lives in the per-service |
nv-dmendoza
left a comment
There was a problem hiding this comment.
LGTM, backports a needed fix
Backports #4029 to
release/v2.0.DPU provisioning can encounter a transient OVS failure when a host PF/VF representor has not materialized yet. That failure currently terminates cloud-init before service restart and Scout execution.
This change keeps the existing OVS configuration and
ofport_requestsynchronization attempts, but makes those operations tolerant of the expected transient failure. The working PF path remains unchanged.Related issues
Type of Change
Breaking Changes
No breaking changes are expected.
Testing
Additional Notes
Cherry-picked from 58959fc.
The production template change is unchanged from the original fix. The associated test was adapted to preserve the existing release/v2.0 assertions.