fix(admin-cli): avoid panic for domainless machine interfaces#3988
Open
AlexGridnev wants to merge 2 commits into
Open
fix(admin-cli): avoid panic for domainless machine interfaces#3988AlexGridnev wants to merge 2 commits into
AlexGridnev wants to merge 2 commits into
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Summary by CodeRabbit
WalkthroughMachine-interface output now resolves known, missing, and unknown domain IDs through a shared helper. Both table and detail formatters render ChangesMachine interface domain resolution
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@crates/admin-cli/src/machine_interfaces/show/cmd.rs`:
- Around line 280-314: Add a table-driven test covering both domainless and
unknown-domain inputs for the formatter functions exercised by
formatters_render_unavailable_domain_name_for_domainless_interface. Include an
unknown Some(domain_id) case with an empty DomainList, and assert
convert_machine_to_nice_format and convert_machines_to_nice_table both render
UNAVAILABLE_DOMAIN_NAME (“NA”) for that case while preserving the existing None
case.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 47b1f109-8059-435d-a3aa-bd82feabbe29
📒 Files selected for processing (1)
crates/admin-cli/src/machine_interfaces/show/cmd.rs
Render unavailable domain names as NA instead of unwrapping them. Add regression coverage for list and detail output with missing or unknown domains. Signed-off-by: Alexey Gridnev <agridnev@nvidia.com>
Add table-driven formatter coverage for domainless and unknown-domain machine interfaces, ensuring both detail and table output render NA. Signed-off-by: Alexey Gridnev <agridnev@nvidia.com>
AlexGridnev
force-pushed
the
fix/domainless-machine-interface-display
branch
from
July 23, 2026 17:53
020c5a4 to
f30ea01
Compare
wminckler
reviewed
Jul 24, 2026
| .map(String::as_str) | ||
| .unwrap_or(UNAVAILABLE_DOMAIN_NAME) | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
one line functions are kinda pointless. and only used once
Contributor
There was a problem hiding this comment.
oh, it is used twice. still kinda pointless ;)
wminckler
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Render unavailable domain names as NA instead of unwrapping them.
Add regression coverage for list and detail output with missing or unknown domains.
Related issues
#3992
Type of Change
Breaking Changes
Testing
Additional Notes