Fix redfish vendor vera rubin#3074
Conversation
WalkthroughThis PR extends Redfish vendor handling so ChangesVeraRubin/P3809 NVIDIA BMC vendor mapping
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
crates/redfish/src/libredfish/conv.rs (1)
150-169: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winAdd a
value_scenarios!case for the new vendor aliases. PinP3809andVeraRubintoBMCVendor::Nvidiaso this mapping stays covered by a table-driven test.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@crates/redfish/src/libredfish/conv.rs` around lines 150 - 169, The bmc_vendor mapping in conv.rs now includes new RedfishVendor aliases P3809 and VeraRubin, but the table-driven coverage in value_scenarios! does not exercise them yet. Add a new value_scenarios! case for bmc_vendor that includes these aliases and asserts they map to BMCVendor::Nvidia, alongside the existing vendor-to-BMCVendor conversions.Source: Path instructions
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@crates/redfish/src/libredfish/conv.rs`:
- Around line 150-169: The bmc_vendor mapping in conv.rs now includes new
RedfishVendor aliases P3809 and VeraRubin, but the table-driven coverage in
value_scenarios! does not exercise them yet. Add a new value_scenarios! case for
bmc_vendor that includes these aliases and asserts they map to
BMCVendor::Nvidia, alongside the existing vendor-to-BMCVendor conversions.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 1306161d-e757-4e28-a576-bfe357d3f106
📒 Files selected for processing (2)
crates/redfish/src/libredfish/conv.rscrates/site-explorer/src/redfish.rs
🔍 Container Scan Summary
Per-CVE detail lives in the per-service |
Backport of #3442 to `release/v2.0`. Newer Dell firmware appends interface details to HTTP boot-option display names. libredfish v0.44.19 preserves the legacy exact-name match while also accepting the suffix used by newer firmware, allowing SetBootOrder to work with both firmware generations. `release/v2.0` previously pinned libredfish v0.44.16, so this backport advances it directly to v0.44.19. This also includes the changes from v0.44.17 and v0.44.18. Because v0.44.18 introduced `RedfishVendor::VeraRubin`, this PR also cherry-picks the compatibility handling from #3074 required to keep the release branch compiling. ## Related issues - Mainline dependency PR: #3442 - VeraRubin compatibility PR: #3074 - libredfish fix: NVIDIA/libredfish#102 - libredfish issue: NVIDIA/libredfish#101 ## Type of Change - [ ] **Add** - New feature or capability - [ ] **Change** - Changes in existing functionality - [x] **Fix** - Bug fixes - [ ] **Remove** - Removed features or deprecated functionality - [ ] **Internal** - Internal changes (refactoring, tests, docs, etc.) ## Breaking Changes - [ ] **This PR contains breaking changes** ## Testing - [x] Unit tests added/updated in the upstream libredfish fix - [ ] Integration tests added/updated - [ ] Manual testing performed - [ ] No testing required Validated on Linux against this backport branch: - `cargo check --locked -p carbide-redfish -p carbide-site-explorer` - focused Clippy for `carbide-redfish` and `carbide-site-explorer` - `cargo make --no-workspace clippy-flow` ## Additional Notes This PR contains two backported mainline commits: - `bec9dfe7c` — bump libredfish to v0.44.19 - `366947aef` — handle the VeraRubin vendor variant introduced by v0.44.18 Release Management should perform the merge. --------- Signed-off-by: Josh P <williamp@nvidia.com> Co-authored-by: hakhondzadeh <hakhondzadeh@nvidia.com>
fix: Add RedfishVendor::VeraRubin to be compatible with libredfish changes.
Bump up the libredfish version
Related issues
Vera Rubin compute tray ingestion.