fix: remove warning message

[ambermingxin]

Description

Checklist

• I am familiar with the Contributing Guidelines.
• New or existing tests cover these changes.
• The documentation is up to date with these changes.

Summary by CodeRabbit

Release Notes

• Documentation

  • Updated DEB and RPM installation verification commands to use elevated system privileges when checking the installed version information.

• Improvements

  • Enhanced GPU UUID validation to accept flexible formatting options while maintaining strict UUID compliance. Added comprehensive test coverage to verify GPU identifier validation functions properly across various input formats and edge cases.

[coderabbitai]

📝 Walkthrough

Walkthrough

This PR introduces two independent changes: installation verification documentation now runs the version check with elevated privileges (sudo), and GPU UUID validation was refactored to support an optional GPU- prefix while maintaining strict UUID format validation.

Changes

Installation Verification

Layer / File(s)	Summary
DEB and RPM installation guides with sudo verification docs/install-deb.md, docs/install-rpm.md	Both DEB and RPM installation guides update the "Verify" step to run fleetint --version with sudo for elevated privileges.

GPU UUID Validation

Layer / File(s)	Summary
GPU UUID validation implementation and tests internal/validation/outbound/validator.go, internal/validation/outbound/validator_test.go	A new validateGPUUUID helper replaces the generic UUID validator for GPU UUID fields, accepting an optional GPU- prefix while validating the remainder as a UUID and emitting warnings for invalid formats. ValidateNodeUpsertRequest now calls this dedicated validator. Test coverage includes subtests for valid NVIDIA UUIDs and malformed UUID rejection with appropriate warning issues.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

A rabbit hops through validation code,
GPU UUIDs now wear their prefix load.
With sudo verify, the guides run clean,
The finest GPU checks we've ever seen! 🐰✨

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 16.67% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check	❓ Inconclusive	The title 'fix: remove warning message' is vague and generic. While changes do include warning-related modifications (a new validateGPUUUID that emits warnings), the PR primarily adds GPU UUID validation logic with test coverage across multiple files including documentation updates. The title does not clearly convey the main changes.	Consider a more descriptive title that captures the main objective, such as 'Add GPU UUID validation with optional GPU- prefix' or 'Implement GPU UUID validation in node upsert requests'.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/remove-warning

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (1)

internal/validation/outbound/validator.go (1)

323-335: 💤 Low value

Accept NVIDIA MIG UUIDs (MIG-*) in validateGPUUUID
validateGPUUUID only strips an optional GPU- prefix before uuid.Parse; it doesn’t handle NVML/nvidia-smi MIG UUIDs which use the MIG-<UUID> prefix, so MIG values will trigger invalid GPU UUID format warnings (currently non-blocking). Consider also stripping MIG- (and adding tests).

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@internal/validation/outbound/validator.go` around lines 323 - 335,
validateGPUUUID currently only strips a "GPU-" prefix before parsing, so
NVML/nvidia-smi MIG IDs like "MIG-<UUID>" are rejected; update validateGPUUUID
to also detect and strip a "MIG-" prefix (in addition to "GPU-") before calling
uuid.Parse, preserving existing behavior for empty/trimmed values and appending
the same warning on parse error, and add unit tests covering MIG- prefixed UUIDs
(valid and invalid) to validate the change.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/install-deb.md`:
- Around line 62-63: Update the docs so the version check is consistent and does
not suggest unnecessary privilege: in docs/install-deb.md (and mirror the same
change in docs/install-rpm.md) remove the leading sudo from the example command
so it reads `fleetint --version`; this reflects how the CLI is wired via
cmd/fleetint/root.go using cli.App/app.Version and cli.VersionPrinter which do
not require a Before hook or elevated privileges. If you prefer to keep sudo for
a documented reason, add an explicit rationale in both docs files referencing
the CLI behavior in cmd/fleetint/root.go instead.

---

Nitpick comments:
In `@internal/validation/outbound/validator.go`:
- Around line 323-335: validateGPUUUID currently only strips a "GPU-" prefix
before parsing, so NVML/nvidia-smi MIG IDs like "MIG-<UUID>" are rejected;
update validateGPUUUID to also detect and strip a "MIG-" prefix (in addition to
"GPU-") before calling uuid.Parse, preserving existing behavior for
empty/trimmed values and appending the same warning on parse error, and add unit
tests covering MIG- prefixed UUIDs (valid and invalid) to validate the change.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 459834e9-30ab-4845-8e36-4092dd2c9863

📥 Commits

Reviewing files that changed from the base of the PR and between fd3575b and 3b98dfb.

📒 Files selected for processing (4)

• docs/install-deb.md
• docs/install-rpm.md
• internal/validation/outbound/validator.go
• internal/validation/outbound/validator_test.go