Skip to content

[API] Query String Support - #631

Open
ArielG-NV wants to merge 3 commits into
NVIDIA:mainfrom
ArielG-NV:query-string-support
Open

ArielG-NV wants to merge 3 commits into
NVIDIA:mainfrom
ArielG-NV:query-string-support

Conversation

@ArielG-NV

Copy link
Copy Markdown
Collaborator

Resolves: #628
Partially addresses: #597

Changes:

  • Add support for a QueryString to flashdreams via QueryStringUserInputEvent. Event received by first-step of a UILoop/ModelLoop.
  • Added imgui-ui-query-string demo to test functionality.

Signed-off-by: Ariel Glasroth <aglasroth@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Sep 15, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@NVIDIA NVIDIA deleted a comment from copy-pr-bot Bot Sep 15, 2026
@greptile-apps

greptile-apps Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge.

Summary

WebRTC connections now pass the browser URL query string into the first loop input event. The PR also adds an ImGui demo that reads an RGB color from that query and uses it as the background.

  • Adds query-string support to WebRTC input handling.
  • Adds an RGB background demo driven by the browser URL.
  • Documents and tests the new connection input.

Diagram

sequenceDiagram
    participant Runner as Session runner
    participant Window as WebRTC window
    participant Browser
    participant Server as WebRTC server
    participant Buffer as Event buffer
    participant Loops as UI and model loops
    Runner->>Window: Open session
    Browser->>Server: GET /healthz
    Server-->>Browser: Window is open
    Browser->>Browser: Create offer and gather ICE
    Browser->>Server: POST /api/webrtc/offer + query
    Server->>Server: Read raw_query_string
    Server->>Buffer: Add QueryStringUserInputEvent
    Server-->>Browser: Return SDP answer
    Runner->>Buffer: Read queued input on a loop tick
    Buffer-->>Loops: Give event batch to both loops
Loading

Reviews (3) · Last reviewed commit: "Update flashdreams/flashdreams/runtime_v..."

Comment thread flashdreams/flashdreams/runtime_v2/serving/web/app.js
Comment thread flashdreams/flashdreams/runtime_v2/README.md Outdated
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Signed-off-by: ArielG-NV <159081215+ArielG-NV@users.noreply.github.com>
@ArielG-NV
ArielG-NV marked this pull request as draft September 15, 2026 20:51
@ArielG-NV
ArielG-NV marked this pull request as ready for review September 15, 2026 21:54
@ArielG-NV

Copy link
Copy Markdown
Collaborator Author

/ok to test 4f2676a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[API] QueryString support as a UserInputEvent

2 participants